Fix hanging when zoom out goes below 5px (#3498) #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the font size goes below 5px, xterm starts acting up and hangs. To avoid this, the font-size is set to 5px minimum.
chabou
approved these changes
Mar 5, 2019
| @@ -70,7 +70,8 @@ export function decreaseFontSize() { | |||
| effect() { | |||
| const state = getState(); | |||
| const old = state.ui.fontSizeOverride || state.ui.fontSize; | |||
| const value = old - 1; | |||
| // when the font-size is really small, below 5px, xterm starts showing up issues. | |||
| const value = old > 5 ? old - 1 : old; | |||
There was a problem hiding this comment.
Suggested change
| const value = old > 5 ? old - 1 : old; | |
| const value = Math.max(old - 1, 5); |
I prefer to use max() to floor a value, but this is a personal flavor.
Your way is totally acceptable.
|
Thank you so much for your help @Kacppian 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the font size goes below 5px, xterm starts acting up and hangs. To avoid this,
the font-size is set to 5px minimum.
It's ready to be merged.