Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ssh url handling #7170

Merged
merged 1 commit into from
May 6, 2023
Merged

Conversation

LabhanshAgrawal
Copy link
Collaborator

fixes #6767

new URL() behavior seems to be different across chrome and node, which results in incorrect parsing in the renderer. Sending parsed data over ipc seems to fix this.

@github-actions
Copy link

github-actions bot commented May 6, 2023

Hi there,
Thank you for contributing to Hyper!
You can get the build artifacts from here.
Here are screenshots of Hyper built from this pr.
Imgur Images

@LabhanshAgrawal LabhanshAgrawal merged commit 32eeb6d into vercel:canary May 6, 2023
@LabhanshAgrawal LabhanshAgrawal deleted the ssh-url branch May 6, 2023 06:04
@tendallas
Copy link

I've got problems with installing nightly build on mac. If someone will got system error use this command before:
xattr -cr /Applications/Hyper.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssh://host does not get handled correctly
2 participants