Update CODEOWNERS #22232

divmain · 2021-02-16T19:11:58Z

Adding @leerob and myself, removing @chibicode.

ijjk · 2021-02-16T19:20:52Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	divmain/next.js update-codeowners	Change
buildDuration	11s	11.4s	⚠️ +342ms
nodeModulesSize	69.8 MB	69.8 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	divmain/next.js update-codeowners	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.014	2.009	0
/ avg req/sec	1241.25	1244.58	+3.33
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.25	1.233	-0.02
/error-in-render avg req/sec	2000.02	2027.29	+27.27

Client Bundles (main, webpack, commons)

	vercel/next.js canary	divmain/next.js update-codeowners	Change
677f882d2ed8..5cb0.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	divmain/next.js update-codeowners	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Rendered Page Sizes

	vercel/next.js canary	divmain/next.js update-codeowners	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	609 B	609 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	divmain/next.js update-codeowners	Change
buildDuration	13.2s	13.1s	-17ms
nodeModulesSize	69.8 MB	69.8 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	divmain/next.js update-codeowners	Change
677f882d2ed8..5cb0.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	divmain/next.js update-codeowners	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Serverless bundles

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_error.js	1.01 MB	1.01 MB	✓
404.html	2.67 kB	2.67 kB	✓
amp.amp.html	10.4 kB	10.4 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.01 MB	1.01 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Webpack 5 Mode (Decrease detected ✓)

General

	vercel/next.js canary	divmain/next.js update-codeowners	Change
buildDuration	12.7s	13.1s	⚠️ +470ms
nodeModulesSize	69.8 MB	69.8 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	divmain/next.js update-codeowners	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.985	2.006	⚠️ +0.02
/ avg req/sec	1259.7	1246.5	⚠️ -13.2
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.259	1.27	⚠️ +0.01
/error-in-render avg req/sec	1986.19	1968.04	⚠️ -18.15

Client Bundles (main, webpack, commons)

	vercel/next.js canary	divmain/next.js update-codeowners	Change
597-d08f5fe5..d690.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.9 kB	59.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	divmain/next.js update-codeowners	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_app-6e0a903..b885.js gzip	1.26 kB	1.26 kB	✓
_error-9e190..f9d6.js gzip	3.38 kB	3.38 kB	✓
amp-7fd79cc4..99ee.js gzip	538 B	538 B	✓
hooks-f7e199..11b9.js gzip	904 B	904 B	✓
index-3dc22c..ffbb.js gzip	232 B	232 B	✓
link-7cc9e62..ef27.js gzip	1.66 kB	1.66 kB	✓
routerDirect..323a.js gzip	308 B	308 B	✓
withRouter-a..2ef8.js gzip	304 B	304 B	✓
Overall change	8.59 kB	8.59 kB	✓

Client Build Manifests

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Rendered Page Sizes

	vercel/next.js canary	divmain/next.js update-codeowners	Change
index.html gzip	586 B	586 B	✓
link.html gzip	594 B	594 B	✓
withRouter.html gzip	580 B	580 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "M8uiptO6Hf51yLN1kIzYl",
+        "buildId": "DsedsRu59EeD1B5BLQYyK",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/M8uiptO6Hf51yLN1kIzYl/_buildManifest.js"
+      src="/_next/static/DsedsRu59EeD1B5BLQYyK/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/M8uiptO6Hf51yLN1kIzYl/_ssgManifest.js"
+      src="/_next/static/DsedsRu59EeD1B5BLQYyK/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "M8uiptO6Hf51yLN1kIzYl",
+        "buildId": "DsedsRu59EeD1B5BLQYyK",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/M8uiptO6Hf51yLN1kIzYl/_buildManifest.js"
+      src="/_next/static/DsedsRu59EeD1B5BLQYyK/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/M8uiptO6Hf51yLN1kIzYl/_ssgManifest.js"
+      src="/_next/static/DsedsRu59EeD1B5BLQYyK/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "M8uiptO6Hf51yLN1kIzYl",
+        "buildId": "DsedsRu59EeD1B5BLQYyK",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/M8uiptO6Hf51yLN1kIzYl/_buildManifest.js"
+      src="/_next/static/DsedsRu59EeD1B5BLQYyK/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/M8uiptO6Hf51yLN1kIzYl/_ssgManifest.js"
+      src="/_next/static/DsedsRu59EeD1B5BLQYyK/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: af158ad

ijjk · 2021-02-16T19:24:23Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	divmain/next.js update-codeowners	Change
buildDuration	12.7s	12.4s	-274ms
nodeModulesSize	69.8 MB	69.8 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	divmain/next.js update-codeowners	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.442	2.279	-0.16
/ avg req/sec	1023.93	1096.81	+72.88
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.795	1.723	-0.07
/error-in-render avg req/sec	1393.03	1451.14	+58.11

Client Bundles (main, webpack, commons)

	vercel/next.js canary	divmain/next.js update-codeowners	Change
677f882d2ed8..5cb0.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	divmain/next.js update-codeowners	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Rendered Page Sizes

	vercel/next.js canary	divmain/next.js update-codeowners	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	609 B	609 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	divmain/next.js update-codeowners	Change
buildDuration	14.4s	14.3s	-39ms
nodeModulesSize	69.8 MB	69.8 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	divmain/next.js update-codeowners	Change
677f882d2ed8..5cb0.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	divmain/next.js update-codeowners	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Serverless bundles

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_error.js	1.01 MB	1.01 MB	✓
404.html	2.67 kB	2.67 kB	✓
amp.amp.html	10.4 kB	10.4 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.01 MB	1.01 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General

	vercel/next.js canary	divmain/next.js update-codeowners	Change
buildDuration	14.3s	15.1s	⚠️ +840ms
nodeModulesSize	69.8 MB	69.8 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	divmain/next.js update-codeowners	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.345	2.355	⚠️ +0.01
/ avg req/sec	1066.17	1061.43	⚠️ -4.74
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.67	1.641	-0.03
/error-in-render avg req/sec	1497	1523.73	+26.73

Client Bundles (main, webpack, commons)

	vercel/next.js canary	divmain/next.js update-codeowners	Change
597-d08f5fe5..d690.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.9 kB	59.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	divmain/next.js update-codeowners	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_app-6e0a903..b885.js gzip	1.26 kB	1.26 kB	✓
_error-9e190..f9d6.js gzip	3.38 kB	3.38 kB	✓
amp-7fd79cc4..99ee.js gzip	538 B	538 B	✓
hooks-f7e199..11b9.js gzip	904 B	904 B	✓
index-3dc22c..ffbb.js gzip	232 B	232 B	✓
link-7cc9e62..ef27.js gzip	1.66 kB	1.66 kB	✓
routerDirect..323a.js gzip	308 B	308 B	✓
withRouter-a..2ef8.js gzip	304 B	304 B	✓
Overall change	8.59 kB	8.59 kB	✓

Client Build Manifests

	vercel/next.js canary	divmain/next.js update-codeowners	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Rendered Page Sizes

	vercel/next.js canary	divmain/next.js update-codeowners	Change
index.html gzip	586 B	586 B	✓
link.html gzip	594 B	594 B	✓
withRouter.html gzip	580 B	580 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "rqVfjKRspC6yJMAIIeqeY",
+        "buildId": "hFbDLx9AWunJA5AfzXQxn",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/rqVfjKRspC6yJMAIIeqeY/_buildManifest.js"
+      src="/_next/static/hFbDLx9AWunJA5AfzXQxn/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/rqVfjKRspC6yJMAIIeqeY/_ssgManifest.js"
+      src="/_next/static/hFbDLx9AWunJA5AfzXQxn/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "rqVfjKRspC6yJMAIIeqeY",
+        "buildId": "hFbDLx9AWunJA5AfzXQxn",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/rqVfjKRspC6yJMAIIeqeY/_buildManifest.js"
+      src="/_next/static/hFbDLx9AWunJA5AfzXQxn/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/rqVfjKRspC6yJMAIIeqeY/_ssgManifest.js"
+      src="/_next/static/hFbDLx9AWunJA5AfzXQxn/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "rqVfjKRspC6yJMAIIeqeY",
+        "buildId": "hFbDLx9AWunJA5AfzXQxn",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/rqVfjKRspC6yJMAIIeqeY/_buildManifest.js"
+      src="/_next/static/hFbDLx9AWunJA5AfzXQxn/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/rqVfjKRspC6yJMAIIeqeY/_ssgManifest.js"
+      src="/_next/static/hFbDLx9AWunJA5AfzXQxn/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: af158ad

GitBash-ux · 2021-03-07T19:01:15Z

.github/CODEOWNERS

@@ -1,6 +1,6 @@
 # Learn how to add code owners here:
 # https://help.github.com/en/articles/about-code-owners

-*          @timneutkens @Timer @ijjk @lfades


@timneutkens @Timer @ijjk @lfades @divmain

/docs/ @timneutkens @Timer @ijjk @lfades @divmain @leerob

Write Preview

Attach files by dragging & dropping, selecting or pasting them.
Add review comment
Cancel

/examples/ @timneutkens @Timer @ijjk @lfades @divmain @leerob

GitBash-ux · 2021-03-07T19:02:30Z

.github/CODEOWNERS

@@ -1,6 +1,6 @@
 # Learn how to add code owners here:
 # https://help.github.com/en/articles/about-code-owners

-*          @timneutkens @Timer @ijjk @lfades
-/docs/     @timneutkens @Timer @ijjk @lfades @chibicode


/docs/ @timneutkens @Timer @ijjk @lfades @divmain @leerob
Write

[ ]

Update CODEOWNERS.

af158ad

divmain requested review from ijjk, lfades, Timer and timneutkens as code owners February 16, 2021 19:11

ijjk approved these changes Feb 16, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

ijjk merged commit 1433f7a into vercel:canary Feb 16, 2021

This was referenced Mar 5, 2021

Bump next from 10.0.5 to 10.0.8 macrat/blanktar#639

Closed

Bump next from 10.0.7 to 10.0.8 appare45/pandora#8

Merged

Bump next from 10.0.5 to 10.0.8 iLek2428/dmg-blog#25

Closed

Bump next from 9.5.3 to 10.0.8 DDDEastMidlandsLimited/dddem-web#202

Closed

GitBash-ux reviewed Mar 7, 2021

View reviewed changes

This was referenced Mar 15, 2021

Bump next from 9.5.3 to 10.0.8 Jam52/dddem-web#2

Closed

Bump next from 10.0.6 to 10.0.8 Danrrodrigues/boilerplate-react-next#228

Closed

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CODEOWNERS #22232

Update CODEOWNERS #22232

divmain commented Feb 16, 2021

ijjk commented Feb 16, 2021

Diffs

ijjk commented Feb 16, 2021

Diffs

This comment has been minimized.

GitBash-ux Mar 7, 2021

GitBash-ux Mar 7, 2021

GitBash-ux Mar 7, 2021

Update CODEOWNERS #22232

Update CODEOWNERS #22232

Conversation

divmain commented Feb 16, 2021

ijjk commented Feb 16, 2021

Stats from current PR

Diffs

ijjk commented Feb 16, 2021

Stats from current PR

Diffs

This comment has been minimized.

GitBash-ux Mar 7, 2021

Choose a reason for hiding this comment

GitBash-ux Mar 7, 2021

Choose a reason for hiding this comment

GitBash-ux Mar 7, 2021

Choose a reason for hiding this comment