-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving to upstash and new integration #22436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahfschr
requested review from
divmain,
ijjk,
leerob,
lfades,
Timer and
timneutkens
as code owners
February 22, 2021 21:52
leerob
reviewed
Feb 23, 2021
removing <br>'s Co-authored-by: Lee Robinson <me@leerob.io>
leerob
reviewed
Feb 23, 2021
Co-authored-by: Lee Robinson <me@leerob.io>
@leerob resolved your comments. can you review again please? |
@noahfschr looks like linting failed due to formatting. Could you ensure |
leerob
previously approved these changes
Feb 24, 2021
Thank you @noahfschr! 🙌 |
Still an issue with |
leerob
previously approved these changes
Feb 24, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.