Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The component load order between targets should match #22732

Closed
ijjk opened this issue Mar 3, 2021 · 1 comment · Fixed by #22731
Closed

The component load order between targets should match #22732

ijjk opened this issue Mar 3, 2021 · 1 comment · Fixed by #22731
Assignees
@ijjk
Milestone
iteration 17

Comments

@ijjk
Copy link
Member

ijjk commented Mar 3, 2021 •
edited
Loading

We should ensure the order of loading _document, _app, and the page's component should match between the serverless target and the default server target.
@ijjk ijjk self-assigned this Mar 3, 2021
@ijjk ijjk mentioned this issue Mar 3, 2021
Merged
@kodiakhq kodiakhq bot closed this as completed in #22731 Mar 3, 2021
@Timer Timer added this to the iteration 17 milestone Mar 3, 2021
kodiakhq bot pushed a commit that referenced this issue Mar 3, 2021
@ijjk
Ensure component load order (#22731)
1435de1 
This ensures we load `_document` then `_app` and then the page's component in all cases which matches behavior between the serverless target and the default server target.  Additional tests to ensure this order is followed has been added to prevent regression. 

Fixes: #22732
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ijjk ijjk

Labels
None yet
Projects
None yet
Milestone
iteration 17
Development

Successfully merging a pull request may close this issue.

Ensure component load order ijjk/next.js
3 participants
@Timer @balazsorban44 @ijjk