Routing error in dev mode: TypeError: Cannot read property 'includes' of undefined (take two) #38047
Closed
1 task done
Labels
bug
Issue was opened via the bug report template.
Comments
2 tasks
kodiakhq bot
pushed a commit
that referenced
this issue
Aug 7, 2022
) ## Bug - [x] Fixes #38047 - ~[ ] Integration tests added: do you want them added for such an unusual edge case?~ [Comment below: skipping](#38046 (comment)) - [x] Errors have helpful link attached, see `contributing.md`: ~I'll wait until this approach & error message are confirmed before thinking more deeply on how to explain the error~ Sending a draft PR as reference ahead of time. 🙂 Doesn't resolve the root issue of why `_devPagesManifest.json` might fail to load. But does improve the log for when it happens. I'd suggest applying this same fix to `_devMiddlewareManifest.json` too. <table> <thead> <tr> <th></th> <th>Before</th> <th>After</th> </tr> </thead> <tbody> <tr> <th>Console</th> <td> <pre> <code> Failed to fetch devPagesManifest TypeError: Failed to fetch at PageLoader.getPageList (page-loader.js?e87a:30:53) at _callee$ (router.js?8684:955:45) at ... </code> </pre> <pre> <code> router.js?8684:1319 Uncaught (in promise) TypeError: Cannot \ read properties of undefined (reading 'includes') at resolveDynamicRoute (router.js?8684:1319:16) at _callee$ at ... </code> </pre> </td> <td> <pre> <code> Failed to fetch devPagesManifest: TypeError: Failed to fetch at PageLoader.getPageList (page-loader.js?e87a:30:53) at _callee$ (router.js?8684:955:45) at ... </code> </pre> </td> </tr> <tr> <th>Visual</th> <td><img alt="Screenshot of a Next.js runtime error: TypeError: Cannot read properties of undefined (reading 'includes')" src="https://user-images.githubusercontent.com/3335181/175854728-8d5c2051-1229-4da7-8af1-fc95236befae.png" /></td> <td><img alt="Screenshot of a Next.js runtime error: Error: Failed to fetch _devPagesManifest.json. Is something blocking that network request?" src="https://user-images.githubusercontent.com/3335181/175854774-07895846-1a1c-4bb8-bf57-fa696b8c6ba4.png" /></td> </tr> </tbody> </table>
|
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Verify canary release
Provide environment information
What browser are you using? (if relevant)
Chrome, but n/a
How are you deploying your application? (if relevant)
n/a
Describe the Bug
#16874 is still impacting users. I have a repro! If the network request to
/_next/static/development/_devPagesManifest.jsonfails for any reason, the Next.js dev application crashes with:Expected Behavior
Next.js should be resilient to that manifest failing to load.
I took a dive into the source code and there are some spicy TypeScript shenanigans happening 😄. And some TODOs about handling this correctly! #38046 is a draft PR showing what I'd suggest doing to resolve this issue.
if (pages.includes(fsPathname))pagesis a parameter ofresolveRewritesresolveRewrites,pagescomes fromthis.pageLoader.getPageList()getPageListdoesn't properly handle the case offetch(.../_next/static/development/_devPagesManifest.json)failing:return this.promisedDevPagesManifest!has a// TODO Remove this assertion as this could be undefinedcommentLink to reproduction
https://stackblitz.com/edit/vercel-next-js-flnphe?file=pages%2Findex.tsx
(really, any Next.js app with a
Linkcan demonstrate this issue)To Reproduce
<Link>somewhere on the pageStep 3 is the easiest way to simulate any of the reasons why that URL wouldn't be accessible that are mentioned in #16874. Apparently nginx configurations are more common culprits. Anecdotally I think I've seen this on CI runs that have flaky network layers (both GitHub Actions and CircleCI).
The text was updated successfully, but these errors were encountered: