Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: next/link-passhref isn't included in the linting plugin anymore (?) #42159

Open
MariaSolOs opened this issue Oct 29, 2022 · 2 comments
Open

Comments

@MariaSolOs
Copy link
Contributor

What is the improvement or update you wish to see?

I was reviewing the latest changes of next/link and noticed that the docs refer to a next/link-passhref ESLint rule, but I couldn't find its definition in the Next plugin. Was this rule removed? And if so, the docs should be updated.

Is there any context that might help us understand?

With the new changes introduced by Next 13, is important for the docs to be up to date!

Does the docs page already exist? Please link to it.

https://nextjs.org/docs/api-reference/next/link#if-the-child-is-a-custom-component-that-wraps-an-a-tag

@MariaSolOs MariaSolOs added the Documentation Related to Next.js' official documentation. label Oct 29, 2022
@dan-b-hu
Copy link

dan-b-hu commented Jun 1, 2023

Yes, looks like it was removed.
#36511
Although I don't think it should have been! In a few cases, we're using legacyBehavior which seems to still require passHref?

@WillsB3
Copy link

WillsB3 commented Nov 10, 2023

I've noticed this too. The documentation mentions this rule and I was confused as to why I couldn't trigger a linting error from this rule.

Does the documentation need updating or does this lint rule need bringing back and potentially updating?
In my debugging I got a config dump form eslint for the file I was editing and can see that there is no next/link-passhref rule listed in the generated rules section of the config being passed to eslint.

Does the documentation just need updating or does this lint rule need bringing back?

@samcx samcx removed the Documentation Related to Next.js' official documentation. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants