-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic = 'error' throws exception on very simple static page #43059
Labels
area: app
App directory (appDir: true)
Comments
balazsorban44
added
area: app
App directory (appDir: true)
kind: bug
and removed
bug
Issue was opened via the bug report template.
labels
Nov 18, 2022
11 tasks
ijjk
pushed a commit
that referenced
this issue
Nov 26, 2022
`export const dynamic = "error"` should only throw if the page actually didn't get exported during `next build`. Test already exist to make sure it throws: `test/integration/app-dynamic-error/app/dynamic-error/page.js` Fixes #43059 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
brvnonascimento
pushed a commit
to brvnonascimento/next.js
that referenced
this issue
Nov 28, 2022
…el#43377) `export const dynamic = "error"` should only throw if the page actually didn't get exported during `next build`. Test already exist to make sure it throws: `test/integration/app-dynamic-error/app/dynamic-error/page.js` Fixes vercel#43059 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Verify canary release
Provide environment information
What browser are you using? (if relevant)
No response
How are you deploying your application? (if relevant)
No response
Describe the Bug
I have a freshly installed next@canary build (
yarn create next-app --experimental-app
).I created a simple page with the following code (located in
app/test/page.tsx
):When running
yarn build
, I get an exception:This is a very simple static page with no dynamic fetches, so
dynamic = 'error'
shouldn't throw any exceptions.Expected Behavior
The static page should get generated with no issue.
Link to reproduction - Issues with a link to complete (but minimal) reproduction code will be addressed faster
https://github.com/seeARMS/nextjs-dynamic-repro
To Reproduce
yarn build
The text was updated successfully, but these errors were encountered: