Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global-error.js not catching exceptions as expected according to the official doc #53756

Closed
1 task done
LIIIIINN opened this issue Aug 8, 2023 · 7 comments · Fixed by #60539
Closed
1 task done

Global-error.js not catching exceptions as expected according to the official doc #53756

LIIIIINN opened this issue Aug 8, 2023 · 7 comments · Fixed by #60539
Assignees
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. locked

Comments

@LIIIIINN
Copy link

LIIIIINN commented Aug 8, 2023

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
      Platform: darwin
      Arch: x64
      Version: Darwin Kernel Version 22.5.0: Thu Jun  8 22:22:22 PDT 2023; root:xnu-8796.121.3~7/RELEASE_X86_64
    Binaries:
      Node: 18.16.1
      npm: 9.5.1
      Yarn: N/A
      pnpm: N/A
    Relevant Packages:
      next: 13.4.13
      eslint-config-next: 13.4.13
      react: 18.2.0
      react-dom: 18.2.0
      typescript: 5.1.6
    Next.js Config:
      output: N/A

Which area(s) of Next.js are affected? (leave empty if unsure)

No response

Link to the code that reproduces this issue or a replay of the bug

n/a

To Reproduce

  1. clone a template of nextjs
  2. add throw error in rootLayout or page under app folder
  3. add a new file under app folder, global-error.js as doc described
  4. spin up next app
  5. as you can see from the screen, global-error not triggered

Describe the Bug

exception should be catched by global-error.js file, but not

Expected Behavior

excepted to be catched by global-error.js

Which browser are you using? (if relevant)

chrome

How are you deploying your application? (if relevant)

local

NEXT-1760

@LIIIIINN LIIIIINN added the bug Issue was opened via the bug report template. label Aug 8, 2023
@jpizzati-uvl
Copy link

I'm experiencing same issue. At the moment only workaround is to use _error.js file inside /pages directory to handle exceptions.

@huozhi huozhi added the please add a complete reproduction The issue lacks information for further investigation label Nov 30, 2023
Copy link
Contributor

We cannot recreate the issue with the provided information. Please add a reproduction in order for us to be able to investigate.

Why was this issue marked with the please add a complete reproduction label?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We prefer a link to a public GitHub repository (template for App Router, template for Pages Router), but you can also use these templates: CodeSandbox: App Router or CodeSandbox: Pages Router.

To make sure the issue is resolved as quickly as possible, please make sure that the reproduction is as minimal as possible. This means that you should remove unnecessary code, files, and dependencies that do not contribute to the issue. Ensure your reproduction does not depend on secrets, 3rd party registries, private dependencies, or any other data that cannot be made public. Avoid a reproduction including a whole monorepo (unless relevant to the issue). The easier it is to reproduce the issue, the quicker we can help.

Please test your reproduction against the latest version of Next.js (next@canary) to make sure your issue has not already been fixed.

If you cannot create a clean reproduction, another way you can help the maintainers' job is to pinpoint the canary version of next that introduced the issue. Check out our releases, and try to find the first canary release that introduced the issue. This will help us narrow down the scope of the issue, and possibly point to the PR/code change that introduced it. You can install a specific version of next by running npm install next@<version>.

I added a link, why was it still marked?

Ensure the link is pointing to a codebase that is accessible (e.g. not a private repository). "example.com", "n/a", "will add later", etc. are not acceptable links -- we need to see a public codebase. See the above section for accepted links.

What happens if I don't provide a sufficient minimal reproduction?

Issues with the please add a complete reproduction label that receives no meaningful activity (e.g. new comments with a reproduction link) are automatically closed and locked after 30 days.

If your issue has not been resolved in that time and it has been closed/locked, please open a new issue with the required reproduction.

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps. Furthermore, you can upvote the issue using the 👍 reaction on the topmost comment (please do not comment "I have the same issue" without reproduction steps). Then, we can sort issues by votes to prioritize.

I think my reproduction is good enough, why aren't you looking into it quicker?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@huozhi
Copy link
Member

huozhi commented Nov 30, 2023

Can you share a reproduction that where it couldn't catch and in which mode (next dev or next start)? In dev mode it will display error dialog to let you discover the error and it will show global-error in production mode

@huozhi huozhi self-assigned this Nov 30, 2023
@lforst
Copy link
Contributor

lforst commented Nov 30, 2023

It took me an embarrassingly long time to repro this: https://github.com/lforst/next-global-error-bug

The readme in that repo has the repro instructions.

@huozhi huozhi added linear: next Confirmed issue that is tracked by the Next.js team. and removed please add a complete reproduction The issue lacks information for further investigation labels Nov 30, 2023
@icazemier
Copy link

I did a similar reproduction. Maybe helpful?
#46964 (comment)

@kiddicodes
Copy link

I believe that you are just generating the error in a way that shouldn't actually render the global-error.tsx?

It is supposed to handle error generated in the rendering of the root layout right?
@lforst your repro is generating the error down in the page level, correct? That should probably be handled by an error-boundary (error.tsx)

Not sure about your repro @icazemier but it feels wrong to have it in a setTimeout like that (no async/await for a promise or anything). It feels correct that the page should render and then the error occurs.

The way I've been able to get the error to actually show itself is to do something like this within the root layout:

  if (x > 0.6) {
    throw new Error('Random error')
  }

And ofcourse make sure to build & start

The random throwing error snippet above also triggers the global-error when included in a ServerComponent used by the layout.

huozhi added a commit that referenced this issue Jan 11, 2024
## What

This fixes when the deep nested routes throws a client side error, it
can still be caught by the `global-error.js`

## How

We should always resolve global-error from root app directory instead of
current route's layout. Also fixed a bad test before where the
gloabl-error.js is not located correctly


Fixes #53756
Closes NEXT-1760
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. locked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants