Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate NextMode checks #62106

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Consolidate NextMode checks #62106

merged 8 commits into from
Feb 15, 2024

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Feb 15, 2024

What?

Consolidating the checks for NextMode so that it's easier to find where it's implemented.

Closes NEXT-2508

@timneutkens timneutkens requested review from ijjk, shuding, huozhi and a team as code owners February 15, 2024 16:36
@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Next.js team PRs by the Next.js team. type: next labels Feb 15, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Feb 15, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 15, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js 02-15-Consolidate_NextMode_checks Change
buildDuration 21.9s 21.9s N/A
buildDurationCached 9.5s 8.3s N/A
nodeModulesSize 196 MB 196 MB N/A
nextStartRea..uration (ms) 442ms 441ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-15-Consolidate_NextMode_checks Change
1068-HASH.js gzip 30.2 kB 30.2 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.5 kB N/A
4944-HASH.js gzip 5.04 kB 5.03 kB N/A
8423.HASH.js gzip 181 B 181 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 241 B
main-HASH.js gzip 32.1 kB 32.1 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 47.3 kB 47.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-15-Consolidate_NextMode_checks Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 02-15-Consolidate_NextMode_checks Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 931 B 931 B
Client Build Manifests
vercel/next.js canary vercel/next.js 02-15-Consolidate_NextMode_checks Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-15-Consolidate_NextMode_checks Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 525 B 524 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-15-Consolidate_NextMode_checks Change
edge-ssr.js gzip 94.4 kB 94.5 kB N/A
page.js gzip 151 kB 151 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 02-15-Consolidate_NextMode_checks Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 44.4 kB 44.4 kB N/A
edge-runtime..pack.js gzip 1.94 kB 1.94 kB
Overall change 2.72 kB 2.72 kB
Next Runtimes
vercel/next.js canary vercel/next.js 02-15-Consolidate_NextMode_checks Change
app-page-exp...dev.js gzip 166 kB 166 kB
app-page-exp..prod.js gzip 95.6 kB 95.6 kB
app-page-tur..prod.js gzip 97.3 kB 97.3 kB
app-page-tur..prod.js gzip 91.8 kB 91.8 kB
app-page.run...dev.js gzip 136 kB 136 kB
app-page.run..prod.js gzip 90.3 kB 90.3 kB
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.6 kB 14.6 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.6 kB 14.6 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 50 kB 50 kB
Overall change 925 kB 925 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-15-Consolidate_NextMode_checks Change
0.pack gzip 1.55 MB 1.55 MB N/A
index.pack gzip 103 kB 104 kB ⚠️ +152 B
Overall change 103 kB 104 kB ⚠️ +152 B
Commit: 769173c

This reverts commit 0e542d8c43af5bc09a78e4721114d1c062ddd4a0.
This reverts commit aa345cb2f0febb2971b4c34584029c0c9e96388c.
@kwonoj kwonoj merged commit afd22c0 into canary Feb 15, 2024
71 checks passed
@kwonoj kwonoj deleted the 02-15-Consolidate_NextMode_checks branch February 15, 2024 22:19
@github-actions github-actions bot added the locked label Mar 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants