Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme should mention public is an experimental feature #7800

Closed
dbachrach opened this issue Jul 8, 2019 · 6 comments · Fixed by #7810
Closed

Readme should mention public is an experimental feature #7800

dbachrach opened this issue Jul 8, 2019 · 6 comments · Fixed by #7810
Milestone

Comments

@dbachrach
Copy link

Bug report

Describe the bug

The README contains this line:

To serve static files from the root directory you can add a folder called public and reference those files from the root, e.g: /robots.txt.

However #7771 made this feature experimental. It should either be removed from the readme or the experimental flag to enable it should be mentioned.

To Reproduce

Read README (https://github.com/zeit/next.js)

Expected behavior

Should not include experimental features or should mention that the feature is experimental.

Screenshots

N/A

System information

N/A

Additional context

N/A

@Timer Timer added this to the 9.0.1 milestone Jul 8, 2019
@c0b41
Copy link
Contributor

c0b41 commented Jul 8, 2019

same as middleware #7647

@pkrawc
Copy link
Contributor

pkrawc commented Jul 8, 2019

@Timer Will this be marked as experimental or made a production feature? I don't want to move to this from having a static build with zeit until I don't have to worry about this not changing, but this is a perfect fit for service workers since they need to be served from the root path.

@Timer
Copy link
Member

Timer commented Jul 9, 2019

@pkrawc It's marked experimental until we deprecate static/, but it's stable for all intents and purposes. You can opt-into it and use it if you'd like (the migration will quite literally be to move ./static/ into the ./public/ folder).

Timer added a commit to Timer/next.js that referenced this issue Jul 9, 2019
Timer added a commit that referenced this issue Jul 9, 2019
@jkjustjoshing
Copy link

Is there a place all the current experimental features are listed/documented?

@Timer
Copy link
Member

Timer commented Sep 19, 2019

No @jkjustjoshing, you can find them in the code, though!

The two I'd suggest to try in your apps are experimental: { publicDirectory: true, granularChunks: true }!

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants