Update api-rest-example to SSG #11362

jazibjafri · 2020-03-26T05:31:28Z

Related to #11014

ijjk · 2020-03-26T05:37:39Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
buildDuration	10.9s	11s	⚠️ +87ms
nodeModulesSize	53 MB	53 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
index.html gzip	918 B	918 B	✓
link.html gzip	926 B	926 B	✓
withRouter.html gzip	914 B	914 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Increase detected ⚠️)

General

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
buildDuration	11.7s	11.7s	⚠️ +88ms
nodeModulesSize	53 MB	53 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_error.js gzip	294 kB	293 kB	-53 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	957 B	957 B	✓
index.js gzip	294 kB	294 kB	⚠️ +2 B
link.js gzip	302 kB	302 kB	-3 B
routerDirect.js gzip	300 kB	300 kB	⚠️ +390 B
withRouter.js gzip	300 kB	300 kB	⚠️ +39 B
Overall change	1.49 MB	1.49 MB	⚠️ +375 B

ijjk · 2020-03-26T12:05:08Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
buildDuration	12.2s	11.9s	-293ms
nodeModulesSize	53 MB	53 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
index.html gzip	918 B	918 B	✓
link.html gzip	926 B	926 B	✓
withRouter.html gzip	914 B	914 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Increase detected ⚠️)

General

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
buildDuration	12.2s	12.4s	⚠️ +114ms
nodeModulesSize	53 MB	53 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_error.js gzip	294 kB	293 kB	-757 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	957 B	957 B	✓
index.js gzip	293 kB	293 kB	⚠️ +115 B
link.js gzip	301 kB	301 kB	-69 B
routerDirect.js gzip	299 kB	300 kB	⚠️ +764 B
withRouter.js gzip	300 kB	300 kB	-35 B
Overall change	1.49 MB	1.49 MB	⚠️ +18 B

lfades · 2020-03-26T17:51:49Z

Hi @jazibjafri Thank you for the PR, can you change it to use SWR instead of using SSG/SSR 🙏 . Reason for this is that SSG methods don't need to access the local API endpoints, because they can handle the db directly. And because the example is about API routes, then better to do client side data fetching to the API with SWR instead.

jazibjafri · 2020-03-26T17:55:43Z

Yeah I'll do it. I'm learning so much about next.js. Thank you!

jazibjafri · 2020-03-26T18:07:54Z

Also can you point me to an example with swr, so I can do it correctly.

lfades · 2020-03-26T18:29:02Z

You can use the examples they have in their Quick Start, you can add a very simple loading state and point to the relative URL of the API endpoint just like they're doing there.

lfades · 2020-03-26T22:54:11Z

@jazibjafri You can use this PR I created to update a similar example as reference: https://github.com/zeit/next.js/pull/11383/files

… into update-api-rest

ijjk · 2020-03-27T03:37:02Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
buildDuration	10.6s	10.8s	⚠️ +184ms
nodeModulesSize	53.1 MB	53.1 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
index.html gzip	917 B	917 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	915 B	915 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Increase detected ⚠️)

General

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
buildDuration	11.6s	11.8s	⚠️ +180ms
nodeModulesSize	53.1 MB	53.1 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	JazibJafri/next.js update-api-rest	Change
_error.js gzip	294 kB	294 kB	-73 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	958 B	958 B	✓
index.js gzip	293 kB	294 kB	⚠️ +570 B
link.js gzip	301 kB	302 kB	⚠️ +823 B
routerDirect.js gzip	301 kB	300 kB	-114 B
withRouter.js gzip	300 kB	300 kB	⚠️ +302 B
Overall change	1.49 MB	1.49 MB	⚠️ +1.51 kB

lfades

@jazibjafri Thank you!

jazibjafri · 2020-03-28T18:29:51Z

Thanks alot man, can I ask why do you prefer promise over async/await, and is withRouter not recommended?

lfades · 2020-03-28T18:47:50Z

Because the fetcher is one line and still very simple to understand, which is ideal for examples.
withRouter is recommended, but usually Hooks are preferred.

jazibjafri · 2020-03-29T06:56:48Z

Nice, thanks alot.

Update api-rest-example to SSG

fdf7a9c

jazibjafri requested review from lfades and Timer as code owners March 26, 2020 05:31

Merge branch 'canary' into update-api-rest

c6975bb

jazibjafri added 2 commits March 27, 2020 08:29

Use SWR for data fetching

c4477bb

Merge branch 'update-api-rest' of https://github.com/JazibJafri/next.js…

8ab9701

… into update-api-rest

Updated pages

ca8be06

lfades approved these changes Mar 28, 2020

View reviewed changes

lfades merged commit 9e2ae69 into vercel:canary Mar 28, 2020

snyk-bot mentioned this pull request Apr 13, 2020

[Snyk] Upgrade next from 9.3.2 to 9.3.4 yowainwright/Advanced-React#46

Merged

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update api-rest-example to SSG #11362

Update api-rest-example to SSG #11362

jazibjafri commented Mar 26, 2020

ijjk commented Mar 26, 2020

ijjk commented Mar 26, 2020

lfades commented Mar 26, 2020

jazibjafri commented Mar 26, 2020

jazibjafri commented Mar 26, 2020

lfades commented Mar 26, 2020

lfades commented Mar 26, 2020

ijjk commented Mar 27, 2020

lfades left a comment

jazibjafri commented Mar 28, 2020

lfades commented Mar 28, 2020 •

edited

Loading

jazibjafri commented Mar 29, 2020

Update api-rest-example to SSG #11362

Update api-rest-example to SSG #11362

Conversation

jazibjafri commented Mar 26, 2020

ijjk commented Mar 26, 2020

Stats from current PR

ijjk commented Mar 26, 2020

Stats from current PR

lfades commented Mar 26, 2020

jazibjafri commented Mar 26, 2020

jazibjafri commented Mar 26, 2020

lfades commented Mar 26, 2020

lfades commented Mar 26, 2020

ijjk commented Mar 27, 2020

Stats from current PR

lfades left a comment

Choose a reason for hiding this comment

jazibjafri commented Mar 28, 2020

lfades commented Mar 28, 2020 • edited Loading

jazibjafri commented Mar 29, 2020

lfades commented Mar 28, 2020 •

edited

Loading