load json without extension #1525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: remove extra semicolon. (#1520) Remove master vs README warnning Release 2.0.0 Release 2.0.0-beta.42 Move all NPM modules into a single chunk in dev mode. (#1512) Wait until webpack updates before eval the JSON page. (#1511) Release 2.0.0-beta.41 Revert "Move all NPM modules into a single chunk in dev mode. (#1505)" Release 2.0.0-beta.40 Move all NPM modules into a single chunk in dev mode. (#1505) fixed zeit.co link in readme (#1497) chore(package): update husky to version 0.13.3 (#1491) Add link (#1492) Load the main JS bundle in production with async (#1485) chore(package): update babel-eslint to version 7.2.0 (#1468) Handle pages with no default export and show an error. (#1484) Show errored file always in the error overlay. (#1470) chore(package): update babel-plugin-istanbul to version 4.1.1 (#1481) fix(package): update webpack to version 2.3.1 (#1480) fix(package): update webpack to version 2.3.0 (#1475)
|
Why did you delete this ? |
arunoda
reviewed
Mar 28, 2017
| @@ -280,6 +280,7 @@ export default async function createCompiler (dir, { dev = false, quiet = false, | |||
| } | |||
| }, | |||
| resolve: { | |||
| extensions: ['', '.js', '.jsx', '.json'], | |||
There was a problem hiding this comment.
Remove .jsx. We don't wanna support it. We have talked about this somewhere else.
|
mistake on my part for the delete, adding this back in another pull request. sorry for the confusion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1508
json files don't need the extension.