Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize error-is-clickable test #15606

Merged
merged 3 commits into from
Jul 29, 2020
Merged

Stabilize error-is-clickable test #15606

merged 3 commits into from
Jul 29, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 28, 2020

This attempts to stabilize the error-is-clickable test since it has been flaking recently

Closes: #15585

@ijjk
Copy link
Member Author

ijjk commented Jul 28, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
buildDuration 12.4s 12.2s -200ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.233 2.226 -0.01
/ avg req/sec 1119.44 1123.09 +3.65
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.201 1.217 ⚠️ +0.02
/error-in-render avg req/sec 2081.4 2053.46 ⚠️ -27.94
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-c5a676d..82de.js gzip 6.75 kB 6.75 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-079bffd..dule.js gzip 5.83 kB 5.83 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
index.html gzip 947 B 947 B ✓
link.html gzip 951 B 951 B ✓
withRouter.html gzip 937 B 937 B ✓
Overall change 2.83 kB 2.83 kB ✓
Serverless Mode
General
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
buildDuration 14.2s 13.9s -240ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-c5a676d..82de.js gzip 6.75 kB 6.75 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-079bffd..dule.js gzip 5.83 kB 5.83 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: 35d0c2e

@vercel vercel bot temporarily deployed to Preview July 28, 2020 22:47 Inactive
@vercel vercel deleted a comment from vercel bot Jul 28, 2020
@ijjk
Copy link
Member Author

ijjk commented Jul 28, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
buildDuration 11.1s 11.5s ⚠️ +369ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.031 2.187 ⚠️ +0.16
/ avg req/sec 1231.02 1142.98 ⚠️ -88.04
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.172 1.169 0
/error-in-render avg req/sec 2133.33 2138.7 +5.37
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-c5a676d..82de.js gzip 6.75 kB 6.75 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-079bffd..dule.js gzip 5.83 kB 5.83 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
index.html gzip 947 B 947 B ✓
link.html gzip 951 B 951 B ✓
withRouter.html gzip 937 B 937 B ✓
Overall change 2.83 kB 2.83 kB ✓
Serverless Mode
General
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
buildDuration 12.8s 12.7s -65ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-c5a676d..82de.js gzip 6.75 kB 6.75 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-079bffd..dule.js gzip 5.83 kB 5.83 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: c9ff960

@darshkpatel darshkpatel mentioned this pull request Jul 29, 2020
Merged
@ijjk
Copy link
Member Author

ijjk commented Jul 29, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
buildDuration 13.2s 13.4s ⚠️ +228ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.413 2.363 -0.05
/ avg req/sec 1036.06 1057.97 +21.91
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.431 1.432 0
/error-in-render avg req/sec 1746.53 1746.35 ⚠️ -0.18
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-c5a676d..82de.js gzip 6.75 kB 6.75 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-079bffd..dule.js gzip 5.83 kB 5.83 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
index.html gzip 947 B 947 B ✓
link.html gzip 951 B 951 B ✓
withRouter.html gzip 937 B 937 B ✓
Overall change 2.83 kB 2.83 kB ✓
Serverless Mode
General
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
buildDuration 14.8s 15.1s ⚠️ +208ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-c5a676d..82de.js gzip 6.75 kB 6.75 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-079bffd..dule.js gzip 5.83 kB 5.83 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js stabilize/error-is-clickable Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: 3e4df7e

@kodiakhq kodiakhq bot merged commit 3960783 into vercel:canary Jul 29, 2020
@timneutkens timneutkens deleted the stabilize/error-is-clickable branch July 29, 2020 07:10
LauraBeatris pushed a commit to LauraBeatris/next.js that referenced this pull request Sep 1, 2020
@ijjk @LauraBeatris
Stabilize error-is-clickable test (vercel#15606)
074c0ca 
This attempts to stabilize the `error-is-clickable` test since it has been flaking recently

Closes: vercel#15585
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix new flaking test
2 participants
@ijjk @Timer