Fix: space issue in error overlay and add tests #15617

darshkpatel · 2020-07-29T04:01:35Z

Fixes #15599
The ternary operator condition was swapped, was not caught since previously the error link was towards the end of the message and there was no test for the error message

@ijjk's fixes to the test from Stabilize error-is-clickable test #15606
Use evaluate from next-test-utils
Test for the error message to be the same as the one thrown
Test to check if multiple links in the error are handled properly

ijjk · 2020-07-29T04:08:34Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	9.5s	9.4s	-76ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.733	1.723	-0.01
/ avg req/sec	1442.26	1451.35	+9.09
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	0.95	0.912	-0.04
/error-in-render avg req/sec	2631.72	2741.82	+110.1

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
index.html gzip	947 B	947 B	✓
link.html gzip	951 B	951 B	✓
withRouter.html gzip	937 B	937 B	✓
Overall change	2.83 kB	2.83 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	10.9s	10.7s	-141ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: 419fdff

darshkpatel · 2020-07-29T04:46:31Z

added @ijjk's fixes to the test from #15606 too

ijjk · 2020-07-29T04:54:21Z

Stats from current PR

Default Server Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	13.1s	13.1s	-29ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.379	2.374	0
/ avg req/sec	1050.8	1053.07	+2.27
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.451	1.452	0
/error-in-render avg req/sec	1722.72	1721.45	⚠️ -1.27

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
index.html gzip	947 B	947 B	✓
link.html gzip	951 B	951 B	✓
withRouter.html gzip	937 B	937 B	✓
Overall change	2.83 kB	2.83 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	14.6s	14.9s	⚠️ +320ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: 9762e5e

ijjk · 2020-07-29T05:05:17Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	11.7s	12s	⚠️ +252ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.061	2.074	⚠️ +0.01
/ avg req/sec	1212.83	1205.57	⚠️ -7.26
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.18	1.136	-0.04
/error-in-render avg req/sec	2118.22	2200.94	+82.72

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
index.html gzip	947 B	947 B	✓
link.html gzip	951 B	951 B	✓
withRouter.html gzip	937 B	937 B	✓
Overall change	2.83 kB	2.83 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	13.5s	13.2s	-290ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: 9d331fe

ijjk · 2020-07-29T05:05:17Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	13.2s	13.5s	⚠️ +284ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.387	2.405	⚠️ +0.02
/ avg req/sec	1047.41	1039.43	⚠️ -7.98
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.449	1.491	⚠️ +0.04
/error-in-render avg req/sec	1725.01	1676.93	⚠️ -48.08

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
index.html gzip	947 B	947 B	✓
link.html gzip	951 B	951 B	✓
withRouter.html gzip	937 B	937 B	✓
Overall change	2.83 kB	2.83 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	14.9s	14.7s	-191ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: a963ece

ijjk · 2020-07-29T05:59:58Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	9.5s	9.7s	⚠️ +191ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.732	1.68	-0.05
/ avg req/sec	1443.43	1488.09	+44.66
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	0.945	0.943	0
/error-in-render avg req/sec	2646.2	2651.61	+5.41

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
index.html gzip	947 B	947 B	✓
link.html gzip	951 B	951 B	✓
withRouter.html gzip	937 B	937 B	✓
Overall change	2.83 kB	2.83 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	10.7s	10.5s	-158ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: 06b93f2

ijjk · 2020-07-29T09:15:04Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	13.3s	13.6s	⚠️ +260ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.562	2.43	-0.13
/ avg req/sec	975.92	1028.72	+52.8
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.398	1.455	⚠️ +0.06
/error-in-render avg req/sec	1788	1718.49	⚠️ -69.51

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
index.html gzip	947 B	947 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	937 B	937 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	14.8s	14.7s	-102ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: 31eb842

ijjk · 2020-07-29T09:16:15Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	14.8s	14.7s	-173ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.752	2.68	-0.07
/ avg req/sec	908.55	932.75	+24.2
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.621	1.663	⚠️ +0.04
/error-in-render avg req/sec	1542.03	1503.71	⚠️ -38.32

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
index.html gzip	947 B	947 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	937 B	937 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	16.1s	16s	-20ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: b81188c

test/integration/error-is-clickable/pages/first.js

Co-authored-by: Tim Neutkens <tim@timneutkens.nl>

ijjk · 2020-07-29T09:40:09Z

Failing test suites

Commit: 879ad41

test/integration/error-is-clickable/test/index.test.js

Clickable error link > Shows error message correctly

Expand output

● Clickable error link › Shows error message correctly

expect(received).toMatch(expected)

Expected pattern: /Error: This error should be clickable\. https:\/\/nextjs\.org is the best\. Visit https:\/\/nextjs\.org\/docs for documentation/
Received string:  " 1 of 1 unhandled error
Server Error·
Error: This error should be clickable. https://nextjs.org is the homepage. Visit https://nextjs.org/docs for documentation·
This error happened while generating the page. Any console logs will be displayed in the terminal window."

  91 |     await hasRedbox(browser)
  92 |     const headerText = await getRedboxHeader(browser)
> 93 |     expect(headerText).toMatch(
     |                        ^
  94 |       /Error: This error should be clickable\. https:\/\/nextjs\.org is the best\. Visit https:\/\/nextjs\.org\/docs for documentation/
  95 |     )
  96 |   })

  at Object.<anonymous> (integration/error-is-clickable/test/index.test.js:93:24)

ijjk · 2020-07-29T09:40:13Z

Failing test suites

Commit: 2f5e07e

test/integration/error-is-clickable/test/index.test.js

Clickable error link > Shows error message correctly

Expand output

● Clickable error link › Shows error message correctly

expect(received).toMatch(expected)

Expected pattern: /Error: This error should be clickable\. https:\/\/nextjs\.org is the best\. Visit https:\/\/nextjs\.org\/docs for documentation/
Received string:  " 1 of 1 unhandled error
Server Error·
Error: This error should be clickable. https://nextjs.org is the homepage. Visit https://nextjs.org/docs for documentation·
This error happened while generating the page. Any console logs will be displayed in the terminal window."

  91 |     await hasRedbox(browser)
  92 |     const headerText = await getRedboxHeader(browser)
> 93 |     expect(headerText).toMatch(
     |                        ^
  94 |       /Error: This error should be clickable\. https:\/\/nextjs\.org is the best\. Visit https:\/\/nextjs\.org\/docs for documentation/
  95 |     )
  96 |   })

  at Object.<anonymous> (integration/error-is-clickable/test/index.test.js:93:24)

ijjk · 2020-07-29T09:40:31Z

Stats from current PR

Default Server Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	12.8s	13s	⚠️ +210ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.301	2.279	-0.02
/ avg req/sec	1086.46	1097.07	+10.61
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.295	1.301	⚠️ +0.01
/error-in-render avg req/sec	1930.38	1921.17	⚠️ -9.21

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
index.html gzip	947 B	947 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	937 B	937 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	13.9s	14.2s	⚠️ +299ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: 2f5e07e

ijjk · 2020-07-29T09:42:00Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	14.2s	14s	-162ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.672	2.539	-0.13
/ avg req/sec	935.7	984.78	+49.08
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.584	1.547	-0.04
/error-in-render avg req/sec	1578.05	1615.67	+37.62

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
index.html gzip	947 B	947 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	937 B	937 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	15.8s	16s	⚠️ +254ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: 879ad41

darshkpatel · 2020-07-29T09:45:13Z

Forgot to update message in test after committing #15617 (comment) 2f5e07e

ijjk · 2020-07-29T09:53:31Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	13.3s	13.5s	⚠️ +185ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.426	2.474	⚠️ +0.05
/ avg req/sec	1030.38	1010.34	⚠️ -20.04
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.402	1.456	⚠️ +0.05
/error-in-render avg req/sec	1782.84	1717.21	⚠️ -65.63

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
index.html gzip	947 B	947 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	937 B	937 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
buildDuration	14.5s	14.8s	⚠️ +332ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..b7a9.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-c5a676d..82de.js gzip	6.75 kB	6.75 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
677f882d2ed8..dule.js gzip	6.09 kB	6.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-079bffd..dule.js gzip	5.83 kB	5.83 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	51.8 kB	51.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
Overall change	30.8 kB	30.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js darsh/15599	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: 8593ee9

Timer · 2020-07-29T17:36:44Z

test/integration/error-is-clickable/test/index.test.js


+    await waitFor(1000)


We can't use arbitrary waits in tests, as this will lead to failures. TBH, this test probably doesn't need to check if the browser.url() changes, just that the element itself is an <a>.

Fix spacing issue

419fdff

darshkpatel requested review from ijjk, lfades, Timer and timneutkens as code owners July 29, 2020 04:01

ijjk added the type: next label Jul 29, 2020

ijjk and others added 2 commits July 29, 2020 09:54

Stabilize error-is-clickable test

8aeb901

test to check error message

9762e5e

darshkpatel added 2 commits July 29, 2020 10:25

fix ternary operator condition

a963ece

added types back

9d331fe

add test to check multiple link handling

06b93f2

darshkpatel changed the title ~~Fix spacing issue in error overlay~~ Fix: space issue in error overlay and add tests Jul 29, 2020

darshkpatel added 2 commits July 29, 2020 14:35

Merge remote-tracking branch 'origin' into darsh/15599

31eb842

Merge branch 'canary' into darsh/15599

b81188c

timneutkens previously approved these changes Jul 29, 2020

View reviewed changes

timneutkens reviewed Jul 29, 2020

View reviewed changes

test/integration/error-is-clickable/pages/first.js Outdated Show resolved Hide resolved

Update error message

2f5e07e

Co-authored-by: Tim Neutkens <tim@timneutkens.nl>

darshkpatel dismissed timneutkens’s stale review via 2f5e07e July 29, 2020 09:31

Merge branch 'canary' into darsh/15599

879ad41

update test for message update

8593ee9

darshkpatel requested a review from timneutkens July 29, 2020 09:45

Timer requested changes Jul 29, 2020

View reviewed changes

Timer merged commit c1e5b66 into vercel:canary Jul 29, 2020

Timer mentioned this pull request Jul 29, 2020

Move redbox tests from integration to acceptance suite #15657

Closed

darshkpatel deleted the darsh/15599 branch July 30, 2020 02:41

LauraBeatris pushed a commit to LauraBeatris/next.js that referenced this pull request Sep 1, 2020

Fix: space issue in error overlay and add tests (vercel#15617)

ddbfc46

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: space issue in error overlay and add tests #15617

Fix: space issue in error overlay and add tests #15617

darshkpatel commented Jul 29, 2020 •

edited

Loading

ijjk commented Jul 29, 2020

darshkpatel commented Jul 29, 2020 •

edited

Loading

ijjk commented Jul 29, 2020

ijjk commented Jul 29, 2020

ijjk commented Jul 29, 2020

ijjk commented Jul 29, 2020

ijjk commented Jul 29, 2020

ijjk commented Jul 29, 2020

ijjk commented Jul 29, 2020

ijjk commented Jul 29, 2020

ijjk commented Jul 29, 2020

ijjk commented Jul 29, 2020

darshkpatel commented Jul 29, 2020 •

edited

Loading

ijjk commented Jul 29, 2020

Timer Jul 29, 2020

Fix: space issue in error overlay and add tests #15617

Fix: space issue in error overlay and add tests #15617

Conversation

darshkpatel commented Jul 29, 2020 • edited Loading

ijjk commented Jul 29, 2020

Stats from current PR

darshkpatel commented Jul 29, 2020 • edited Loading

ijjk commented Jul 29, 2020

Stats from current PR

ijjk commented Jul 29, 2020

Stats from current PR

ijjk commented Jul 29, 2020

Stats from current PR

ijjk commented Jul 29, 2020

Stats from current PR

ijjk commented Jul 29, 2020

Stats from current PR

ijjk commented Jul 29, 2020

Stats from current PR

ijjk commented Jul 29, 2020

Failing test suites

ijjk commented Jul 29, 2020

Failing test suites

ijjk commented Jul 29, 2020

Stats from current PR

ijjk commented Jul 29, 2020

Stats from current PR

darshkpatel commented Jul 29, 2020 • edited Loading

ijjk commented Jul 29, 2020

Stats from current PR

Timer Jul 29, 2020

Choose a reason for hiding this comment

darshkpatel commented Jul 29, 2020 •

edited

Loading

darshkpatel commented Jul 29, 2020 •

edited

Loading

darshkpatel commented Jul 29, 2020 •

edited

Loading