Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1301] Save pages as JS, remove eval #1608

Closed
wants to merge 1 commit into from

Conversation

bringking
Copy link

@bringking bringking commented Apr 3, 2017

Subtasks

  • Save pages as plain JS
  • Fetch JS pages from the router
  • Handle 404 pages
  • Handle status codes
  • Send the initial JS/JSON with the __NEXT_DATA__ payload

Related Issue

#1301

Related PRs -

For reference, this work started here - #1548 -> and is now being worked by @arunoda - #1611

@bringking bringking changed the title [#1301] Save pages as JS, expecting a pageLoader abstraction [#1301] Save pages as JS, remove eval Apr 3, 2017
@arunoda arunoda mentioned this pull request Apr 4, 2017
@arunoda
Copy link
Contributor

arunoda commented Apr 4, 2017

Hey actually, I was playing with your code and try to experiment a bit.
So, I came up with this: #1611

After looking at all, I think it's kind better me to work on this feature, since it involves a lot of core changes.
I really need your help and ideas to review #1611 as we proceed.

@bringking
Copy link
Author

@arunoda that sounds like a good plan, it was quite a bit to bite off! I will definitely lend my 👀

@bringking bringking closed this Apr 4, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants