-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add dynamic import support #1750
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need it.
Because that's the place to do it.
arunoda
commented
Apr 18, 2017
lib/dynamic.js
Outdated
super(...args) | ||
this.state = { AsyncComponent: null } | ||
this.isServer = typeof window === 'undefined' | ||
this.loadComponent() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement ssr=false
support.
It was xxxx/page//index.js
Basicaly, now client side routing as they work like in Next.js including prefetching.
Also added a silent option if someone don't want those messages.
We just took this and it's available with Next.js 3.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we are adding TC39 dynamic import support to Next.js
TODO
Basically you could any module asynchronously and do anything you want.
You can use utilities like https://github.com/xtuc/async-reactor without any issues
We've also included some utilities to make your life easier.
1. Create Dynamic Component (Also does SSR)
2. With Custom Loading Component
3. No SSR Support
4. With async-reactor