Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop mutating resolvedAsPath #23705

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Stop mutating resolvedAsPath #23705

merged 2 commits into from
Apr 5, 2021

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Apr 5, 2021 •
edited
Loading

Follow up to #23614. resolvedAsPath isn't actually even being used as an output, we're just mutating it for convenience. If we do want to output it in the future, we can do it a different way (i.e. via return).

@ijjk ijjk added the type: next label Apr 5, 2021
@ijjk
Copy link
Member

ijjk commented Apr 5, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
buildDuration 14s 14s ⚠️ +56ms
nodeModulesSize 45.9 MB 45.9 MB -56 B
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.599 2.442 -0.16
/ avg req/sec 961.77 1023.83 +62.06
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.67 1.704 ⚠️ +0.03
/error-in-render avg req/sec 1497.11 1467.01 ⚠️ -30.1
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_buildManifest.js gzip 370 B 370 B ✓
Overall change 370 B 370 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
buildDuration 16.3s 16.2s -94ms
nodeModulesSize 45.9 MB 45.9 MB -56 B
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_buildManifest.js gzip 370 B 370 B ✓
Overall change 370 B 370 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_error.js 1.36 MB 1.36 MB -21 B
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.36 MB 1.36 MB -21 B
link.js 1.42 MB 1.42 MB -21 B
routerDirect.js 1.41 MB 1.41 MB -21 B
withRouter.js 1.41 MB 1.41 MB -21 B
Overall change 6.99 MB 6.99 MB -105 B
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
buildDuration 16.7s 16.7s ⚠️ +6ms
nodeModulesSize 45.9 MB 45.9 MB -56 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.449 2.501 ⚠️ +0.05
/ avg req/sec 1020.9 999.75 ⚠️ -21.15
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.593 1.697 ⚠️ +0.1
/error-in-render avg req/sec 1569.53 1473.14 ⚠️ -96.39
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
597-e27c5352..db8c.js gzip 13.3 kB 13.3 kB ✓
778-a8e7432f..6391.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
index.html gzip 610 B 610 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "mm6U4I-tpASnO_Gd3mMKK",
+        "buildId": "cFvUwuAaiQVUfGtlg6oAf",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/mm6U4I-tpASnO_Gd3mMKK/_buildManifest.js"
+      src="/_next/static/cFvUwuAaiQVUfGtlg6oAf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/mm6U4I-tpASnO_Gd3mMKK/_ssgManifest.js"
+      src="/_next/static/cFvUwuAaiQVUfGtlg6oAf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "mm6U4I-tpASnO_Gd3mMKK",
+        "buildId": "cFvUwuAaiQVUfGtlg6oAf",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/mm6U4I-tpASnO_Gd3mMKK/_buildManifest.js"
+      src="/_next/static/cFvUwuAaiQVUfGtlg6oAf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/mm6U4I-tpASnO_Gd3mMKK/_ssgManifest.js"
+      src="/_next/static/cFvUwuAaiQVUfGtlg6oAf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "mm6U4I-tpASnO_Gd3mMKK",
+        "buildId": "cFvUwuAaiQVUfGtlg6oAf",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/mm6U4I-tpASnO_Gd3mMKK/_buildManifest.js"
+      src="/_next/static/cFvUwuAaiQVUfGtlg6oAf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/mm6U4I-tpASnO_Gd3mMKK/_ssgManifest.js"
+      src="/_next/static/cFvUwuAaiQVUfGtlg6oAf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 98f8255

@ijjk
Copy link
Member

ijjk commented Apr 5, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
buildDuration 13s 13.3s ⚠️ +314ms
nodeModulesSize 45.9 MB 45.9 MB -56 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.785 2.941 ⚠️ +0.16
/ avg req/sec 897.78 850.06 ⚠️ -47.72
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.62 1.652 ⚠️ +0.03
/error-in-render avg req/sec 1542.9 1512.93 ⚠️ -29.97
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
buildDuration 15.1s 15.3s ⚠️ +228ms
nodeModulesSize 45.9 MB 45.9 MB -56 B
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_error.js 1.37 MB 1.37 MB -21 B
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.37 MB 1.37 MB -21 B
link.js 1.42 MB 1.42 MB -21 B
routerDirect.js 1.42 MB 1.42 MB -21 B
withRouter.js 1.42 MB 1.42 MB -21 B
Overall change 7 MB 7 MB -105 B
Webpack 5 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
buildDuration 15.5s 15.3s -179ms
nodeModulesSize 45.9 MB 45.9 MB -56 B
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.823 2.831 ⚠️ +0.01
/ avg req/sec 885.58 882.95 ⚠️ -2.63
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.706 1.632 -0.07
/error-in-render avg req/sec 1465.02 1532.11 +67.09
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
597-e27c5352..db8c.js gzip 13.3 kB 13.3 kB ✓
778-a8e7432f..6391.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js dont-mutate-resolved-as-path Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "p7X05A_DbVLDdgXg6FJOe",
+        "buildId": "enAXwQmH39LLCQQAOZqOO",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/p7X05A_DbVLDdgXg6FJOe/_buildManifest.js"
+      src="/_next/static/enAXwQmH39LLCQQAOZqOO/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/p7X05A_DbVLDdgXg6FJOe/_ssgManifest.js"
+      src="/_next/static/enAXwQmH39LLCQQAOZqOO/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "p7X05A_DbVLDdgXg6FJOe",
+        "buildId": "enAXwQmH39LLCQQAOZqOO",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/p7X05A_DbVLDdgXg6FJOe/_buildManifest.js"
+      src="/_next/static/enAXwQmH39LLCQQAOZqOO/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/p7X05A_DbVLDdgXg6FJOe/_ssgManifest.js"
+      src="/_next/static/enAXwQmH39LLCQQAOZqOO/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "p7X05A_DbVLDdgXg6FJOe",
+        "buildId": "enAXwQmH39LLCQQAOZqOO",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/p7X05A_DbVLDdgXg6FJOe/_buildManifest.js"
+      src="/_next/static/enAXwQmH39LLCQQAOZqOO/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/p7X05A_DbVLDdgXg6FJOe/_ssgManifest.js"
+      src="/_next/static/enAXwQmH39LLCQQAOZqOO/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 18e7474

@devknoll devknoll marked this pull request as ready for review April 5, 2021 18:27
@kodiakhq kodiakhq bot merged commit 63b96b1 into vercel:canary Apr 5, 2021
@devknoll devknoll deleted the dont-mutate-resolved-as-path branch April 5, 2021 23:18
divmain added a commit to divmain/next.js that referenced this pull request Apr 7, 2021
@divmain
Merge remote-tracking branch 'origin/canary' into babel-turbo-mode
7471fb9 
* origin/canary: (36 commits)
  Fixed issue accessing index page of "with-reason-relay" example (vercel#23780)
  upgrade to webpack 5.31.0 (vercel#23776)
  Add note about prefetching (vercel#23732)
  v10.1.4-canary.2
  Ensure no-op export returns without error (vercel#23752)
  Update to with-supertokens example (vercel#23728)
  Ensure fallback rewrites dont match over pages with i18n (vercel#23674)
  Ensure basePath is not applied for external GSSP redirect (vercel#23673)
  Fix webpack5 cache distDir (vercel#23718)
  v10.1.4-canary.1
  Stop mutating `resolvedAsPath` (vercel#23705)
  Font optimization (vercel#21676)
  v10.1.4-canary.0
  Ensure default fallback values are correct with i18n (vercel#23675)
  Fix: Codeblock Syntax Highlighting (vercel#23545)
  fix with-mqtt-js example. (vercel#23636)
  fix with-styled-jsx-plugins example. (vercel#23635)
  fix with-web-worker example. (vercel#23634)
  fixes a part of vercel#23607 remove with-glamor example (vercel#23639)
  v10.1.3
  ...

# Conflicts:
#	packages/next/package.json
#	yarn.lock
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@devknoll @SokratisVidros
Stop mutating resolvedAsPath (vercel#23705)
f367fe8 
Follow up to vercel#23614. `resolvedAsPath` isn't actually even being used as an output, we're just mutating it for convenience. If we do want to output it in the future, we can do it a different way (i.e. via return).
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devknoll @ijjk