Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webpack5 cache distDir #23718

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Fix webpack5 cache distDir #23718

merged 1 commit into from
Apr 6, 2021

Conversation

felipeptcho
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

Fixes: #23716

@ijjk ijjk added the type: next label Apr 6, 2021
@felipeptcho
Copy link
Contributor Author

I also changed the dist-dir integration test to make sure the .next folder is not created at all. This will be useful when webpack5 becomes the default and will guarantee that this problem with the distDir config does not happen anymore.

@ijjk
Copy link
Member

ijjk commented Apr 6, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
buildDuration 11.6s 11.1s -491ms
nodeModulesSize 45.9 MB 45.9 MB -37 B
Page Load Tests Overall increase ✓
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.393 2.347 -0.05
/ avg req/sec 1044.7 1065.28 +20.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.302 1.239 -0.06
/error-in-render avg req/sec 1919.48 2017.45 +97.97
Client Bundles (main, webpack, commons)
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
index.html gzip 613 B 613 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
buildDuration 13.2s 13.3s ⚠️ +90ms
nodeModulesSize 45.9 MB 45.9 MB -37 B
Client Bundles (main, webpack, commons)
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Serverless bundles
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
_error.js 1.37 MB 1.37 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.37 MB 1.37 MB ✓
link.js 1.42 MB 1.42 MB ✓
routerDirect.js 1.42 MB 1.42 MB ✓
withRouter.js 1.42 MB 1.42 MB ✓
Overall change 7 MB 7 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
buildDuration 12.8s 12.3s -530ms
nodeModulesSize 45.9 MB 45.9 MB -37 B
Page Load Tests Overall increase ✓
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.307 2.24 -0.07
/ avg req/sec 1083.72 1116.02 +32.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.191 1.088 -0.1
/error-in-render avg req/sec 2099.41 2297.52 +198.11
Client Bundles (main, webpack, commons)
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
597-e27c5352..db8c.js gzip 13.3 kB 13.3 kB ✓
778-2fdd7b63..cd87.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary felipeptcho/next.js fix-webpack5-cache-dist-dir Change
index.html gzip 609 B 609 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "WelgjfavTFq3UohFEqGVo",
+        "buildId": "AThe1SE3F1oOEPSTn7HQB",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/WelgjfavTFq3UohFEqGVo/_buildManifest.js"
+      src="/_next/static/AThe1SE3F1oOEPSTn7HQB/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/WelgjfavTFq3UohFEqGVo/_ssgManifest.js"
+      src="/_next/static/AThe1SE3F1oOEPSTn7HQB/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "WelgjfavTFq3UohFEqGVo",
+        "buildId": "AThe1SE3F1oOEPSTn7HQB",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/WelgjfavTFq3UohFEqGVo/_buildManifest.js"
+      src="/_next/static/AThe1SE3F1oOEPSTn7HQB/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/WelgjfavTFq3UohFEqGVo/_ssgManifest.js"
+      src="/_next/static/AThe1SE3F1oOEPSTn7HQB/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "WelgjfavTFq3UohFEqGVo",
+        "buildId": "AThe1SE3F1oOEPSTn7HQB",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/WelgjfavTFq3UohFEqGVo/_buildManifest.js"
+      src="/_next/static/AThe1SE3F1oOEPSTn7HQB/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/WelgjfavTFq3UohFEqGVo/_ssgManifest.js"
+      src="/_next/static/AThe1SE3F1oOEPSTn7HQB/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: b5d3e40

@felipeptcho felipeptcho mentioned this pull request Apr 6, 2021
Closed
timneutkens
timneutkens approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@kodiakhq kodiakhq bot merged commit c2c1b96 into vercel:canary Apr 6, 2021
divmain added a commit to divmain/next.js that referenced this pull request Apr 7, 2021
@divmain
Merge remote-tracking branch 'origin/canary' into babel-turbo-mode
7471fb9 
* origin/canary: (36 commits)
  Fixed issue accessing index page of "with-reason-relay" example (vercel#23780)
  upgrade to webpack 5.31.0 (vercel#23776)
  Add note about prefetching (vercel#23732)
  v10.1.4-canary.2
  Ensure no-op export returns without error (vercel#23752)
  Update to with-supertokens example (vercel#23728)
  Ensure fallback rewrites dont match over pages with i18n (vercel#23674)
  Ensure basePath is not applied for external GSSP redirect (vercel#23673)
  Fix webpack5 cache distDir (vercel#23718)
  v10.1.4-canary.1
  Stop mutating `resolvedAsPath` (vercel#23705)
  Font optimization (vercel#21676)
  v10.1.4-canary.0
  Ensure default fallback values are correct with i18n (vercel#23675)
  Fix: Codeblock Syntax Highlighting (vercel#23545)
  fix with-mqtt-js example. (vercel#23636)
  fix with-styled-jsx-plugins example. (vercel#23635)
  fix with-web-worker example. (vercel#23634)
  fixes a part of vercel#23607 remove with-glamor example (vercel#23639)
  v10.1.3
  ...

# Conflicts:
#	packages/next/package.json
#	yarn.lock
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@felipeptcho @SokratisVidros
Fix webpack5 cache distDir (vercel#23718)
680042f 
## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes

Fixes: vercel#23716
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

distDir is not fully respected when using webpack5
3 participants
@felipeptcho @ijjk @timneutkens