Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure no-op export returns without error #23752

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Ensure no-op export returns without error #23752

merged 1 commit into from
Apr 6, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 6, 2021

This ensures we don't reach the invariant from trying to create the export progress with no items during next build or next export by returning immediately when we notice there are no paths being exported. Additional tests have been added to ensure these cases don't error.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Fixes: #23724

@ijjk ijjk added the type: next label Apr 6, 2021
@ijjk
Copy link
Member Author

ijjk commented Apr 6, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/no-op-export Change
buildDuration 13s 13.4s ⚠️ +394ms
nodeModulesSize 45.9 MB 45.9 MB ⚠️ +158 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/no-op-export Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.795 2.792 0
/ avg req/sec 894.44 895.54 +1.1
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.638 1.669 ⚠️ +0.03
/error-in-render avg req/sec 1525.79 1498.1 ⚠️ -27.69
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/no-op-export Change
677f882d2ed8..e6c6.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/no-op-export Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/no-op-export Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/no-op-export Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/no-op-export Change
index.html gzip 613 B 613 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/no-op-export Change
buildDuration 15.2s 15.4s ⚠️ +195ms
nodeModulesSize 45.9 MB 45.9 MB ⚠️ +158 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/no-op-export Change
677f882d2ed8..e6c6.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/no-op-export Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/no-op-export Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/no-op-export Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/no-op-export Change
_error.js 1.37 MB 1.37 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.37 MB 1.37 MB ✓
link.js 1.42 MB 1.42 MB ✓
routerDirect.js 1.42 MB 1.42 MB ✓
withRouter.js 1.42 MB 1.42 MB ✓
Overall change 7.01 MB 7.01 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/no-op-export Change
buildDuration 15.6s 16.2s ⚠️ +552ms
nodeModulesSize 45.9 MB 45.9 MB ⚠️ +158 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/no-op-export Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.793 2.803 ⚠️ +0.01
/ avg req/sec 895.12 892.06 ⚠️ -3.06
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.647 1.668 ⚠️ +0.02
/error-in-render avg req/sec 1518.13 1498.65 ⚠️ -19.48
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/no-op-export Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-2fdd7b63..cd87.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/no-op-export Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/no-op-export Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/no-op-export Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/no-op-export Change
index.html gzip 612 B 612 B ✓
link.html gzip 617 B 617 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "z1wGduE-7I3h-b5BlmHBr",
+        "buildId": "lp994bznz7y9G_h6C66V9",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/z1wGduE-7I3h-b5BlmHBr/_buildManifest.js"
+      src="/_next/static/lp994bznz7y9G_h6C66V9/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/z1wGduE-7I3h-b5BlmHBr/_ssgManifest.js"
+      src="/_next/static/lp994bznz7y9G_h6C66V9/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "z1wGduE-7I3h-b5BlmHBr",
+        "buildId": "lp994bznz7y9G_h6C66V9",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/z1wGduE-7I3h-b5BlmHBr/_buildManifest.js"
+      src="/_next/static/lp994bznz7y9G_h6C66V9/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/z1wGduE-7I3h-b5BlmHBr/_ssgManifest.js"
+      src="/_next/static/lp994bznz7y9G_h6C66V9/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "z1wGduE-7I3h-b5BlmHBr",
+        "buildId": "lp994bznz7y9G_h6C66V9",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/z1wGduE-7I3h-b5BlmHBr/_buildManifest.js"
+      src="/_next/static/lp994bznz7y9G_h6C66V9/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/z1wGduE-7I3h-b5BlmHBr/_ssgManifest.js"
+      src="/_next/static/lp994bznz7y9G_h6C66V9/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 4d4be88

@kodiakhq kodiakhq bot merged commit 3481150 into vercel:canary Apr 6, 2021
@ijjk ijjk deleted the fix/no-op-export branch April 6, 2021 17:12
divmain added a commit to divmain/next.js that referenced this pull request Apr 7, 2021
@divmain
Merge remote-tracking branch 'origin/canary' into babel-turbo-mode
7471fb9 
* origin/canary: (36 commits)
  Fixed issue accessing index page of "with-reason-relay" example (vercel#23780)
  upgrade to webpack 5.31.0 (vercel#23776)
  Add note about prefetching (vercel#23732)
  v10.1.4-canary.2
  Ensure no-op export returns without error (vercel#23752)
  Update to with-supertokens example (vercel#23728)
  Ensure fallback rewrites dont match over pages with i18n (vercel#23674)
  Ensure basePath is not applied for external GSSP redirect (vercel#23673)
  Fix webpack5 cache distDir (vercel#23718)
  v10.1.4-canary.1
  Stop mutating `resolvedAsPath` (vercel#23705)
  Font optimization (vercel#21676)
  v10.1.4-canary.0
  Ensure default fallback values are correct with i18n (vercel#23675)
  Fix: Codeblock Syntax Highlighting (vercel#23545)
  fix with-mqtt-js example. (vercel#23636)
  fix with-styled-jsx-plugins example. (vercel#23635)
  fix with-web-worker example. (vercel#23634)
  fixes a part of vercel#23607 remove with-glamor example (vercel#23639)
  v10.1.3
  ...

# Conflicts:
#	packages/next/package.json
#	yarn.lock
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@ijjk @SokratisVidros
Ensure no-op export returns without error (vercel#23752)
62223c0 
This ensures we don't reach the invariant from trying to create the export progress with no items during `next build` or `next export` by returning immediately when we notice there are no paths being exported. Additional tests have been added to ensure these cases don't error. 

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added

Fixes: vercel#23724
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: invariant: progress total can not be zero
2 participants
@ijjk @timneutkens