Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for emitting node modules from webpack #2527

Closed
wants to merge 1 commit into from

Conversation

kpdecker
Copy link
Contributor

@kpdecker kpdecker commented Jul 11, 2017

This has two fold impact:

  1. Allows for arbitrary loaders to run in both node and browser environments (Partial for Webpack loader for images to move them to static folder #1825)
  2. Optimizes the build time for modules.

Risks:

  • Transitions all harmony code to utilize harmony end to end. Previously this had not happened, which may break users in unexpected ways. (See Propagate source maps through combine assets step #2508)
  • Require logic changed across the board to utilize node and webpack behaviors where possible, simplifying code, but potentially breaking things in the wild.

This isn't complete, but wanted to open to discuss with collab team.

Open tasks:

  • publicPath dynamic path handling (assetPath, etc)
  • Move existing webpack code into webpack folder for consistency.
  • Further testing, etc

@kpdecker kpdecker changed the base branch from v3-beta to master September 21, 2017 18:06
@nelix
Copy link

nelix commented Sep 25, 2017

This is really impressive work, I can't really fix all my performance issues with a ton of custom config as well as this can...
The webpack plugins are slightly over my head, it would be awesome if some other people could chime in..

This has two fold impact:

1. Allows for arbitrary loaders to run in both node and browser environments (Fixes vercel#1825)
2. Optimizes the build time for modules.

Risks:
- Transitions all harmony code to utilize harmony end to end. Previously this had not happened, which may break users in unexpected ways. (See vercel#2508)
- Require logic changed across the board to utilize node and webpack behaviors where possible, simplifying code, but potentially breaking things in the wild.
@kpdecker
Copy link
Contributor Author

This is way out of date with current impl. Going to revisit and reopen.

@kpdecker kpdecker closed this Oct 30, 2017
@lock
Copy link

lock bot commented May 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants