Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next swc publish flow (redo) #27984

Merged
merged 6 commits into from Aug 12, 2021
Merged

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Aug 11, 2021

This fixes some issues that slipped through in the last PR

The main issue was that lerna publish will fail if there are any changes that have not been committed. To resolve this I added a .gitignore file to ignore the built binaries that are moved into the package and used git update-index --skip-worktree on the package jsons that need to be updated with new versions. The native packages are also being published on their own instead of through lerna publish.

Another issue is that the checkPrecompiled job was sometimes failing unexpectedly because the binaries were changing even when the code and rust toolchain stayed the same. I've only seen this happen with windows and more frequently mac builds, so I changed it to only check the linux build for now while I investigate.

@ijjk

This comment has been minimized.

@padmaia padmaia force-pushed the next-swc-publish-flow branch from 7420620 to cdf928e Compare Aug 12, 2021
@padmaia padmaia closed this Aug 12, 2021
@padmaia padmaia reopened this Aug 12, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 12, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
buildDuration 16s 15.9s -70ms
buildDurationCached 3.6s 3.6s -12ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +28 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
/ failed reqs 0 0
/ total time (seconds) 2.947 3.053 ⚠️ +0.11
/ avg req/sec 848.42 818.81 ⚠️ -29.61
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.862 1.868 ⚠️ +0.01
/error-in-render avg req/sec 1342.86 1338.14 ⚠️ -4.72
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
buildDuration 13s 13s ⚠️ +54ms
buildDurationCached 5.1s 5.1s -8ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +28 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
/ failed reqs 0 0
/ total time (seconds) 3.086 3.096 ⚠️ +0.01
/ avg req/sec 810.19 807.54 ⚠️ -2.65
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.92 1.959 ⚠️ +0.04
/error-in-render avg req/sec 1302.24 1276.29 ⚠️ -25.95
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
index.html gzip 577 B 577 B
link.html gzip 589 B 589 B
withRouter.html gzip 570 B 570 B
Overall change 1.74 kB 1.74 kB
Commit: fb1f477

@timneutkens timneutkens merged commit b2c7b31 into vercel:canary Aug 12, 2021
30 checks passed
@padmaia padmaia deleted the next-swc-publish-flow branch Sep 15, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants