Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next swc publish flow #27932

Merged
merged 12 commits into from Aug 11, 2021
Merged

Next swc publish flow #27932

merged 12 commits into from Aug 11, 2021

Conversation

@padmaia
Copy link
Member

@padmaia padmaia commented Aug 10, 2021

This PR sets up next-swc for publishing. Each binary will get published as its own npm package and will be listed as an optionalDependency so npm/yarn/pnpm will take care of downloading the correct one. These packages cannot live under the packages directory as it breaks yarn install, so they are kept at packages/next/build/swc/npm and are moved and versioned right before publishing. This is currently only building the 4 main targets, planning to build the rest in a follow up.

@ijjk

This comment has been hidden.

@padmaia padmaia force-pushed the next-swc-publish-flow branch from daae38c to ff97f6d Aug 10, 2021
@ijjk

This comment has been hidden.

@padmaia padmaia marked this pull request as ready for review Aug 11, 2021
@ijjk
Copy link
Member

@ijjk ijjk commented Aug 11, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
buildDuration 15.3s 15.2s -40ms
buildDurationCached 3.5s 3.4s -78ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +20 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
/ failed reqs 0 0
/ total time (seconds) 2.739 2.66 -0.08
/ avg req/sec 912.69 939.87 +27.18
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.488 1.554 ⚠️ +0.07
/error-in-render avg req/sec 1679.85 1608.82 ⚠️ -71.03
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 523 B 523 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
buildDuration 12.7s 12.6s -127ms
buildDurationCached 5s 4.9s -93ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +20 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
/ failed reqs 0 0
/ total time (seconds) 2.731 2.768 ⚠️ +0.04
/ avg req/sec 915.46 903.3 ⚠️ -12.16
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.512 1.564 ⚠️ +0.05
/error-in-render avg req/sec 1653.15 1598.1 ⚠️ -55.05
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js next-swc-publish-flow Change
index.html gzip 577 B 577 B
link.html gzip 589 B 589 B
withRouter.html gzip 570 B 570 B
Overall change 1.74 kB 1.74 kB
Commit: bee8fbf

@timneutkens timneutkens merged commit 94fc6f0 into vercel:canary Aug 11, 2021
31 checks passed
timneutkens added a commit that referenced this issue Aug 11, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this issue Aug 19, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this issue Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants