with-stitches example fixes #28650 #28652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobEasthope
requested review from
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
peduarte
reviewed
Sep 6, 2021
|
Hey, thanks for this! The utils API has changed also. So that'll need to be updated in the config. |
No worries, I've updated the utils syntax as well |
bordeo
pushed a commit
to filoblu/next.js
that referenced
this pull request
Sep 7, 2021
* canary: Remove unused profiler (vercel#28844) Remove outdated webpack conformance experiment (vercel#28846) v11.1.3-canary.13 v11.1.3-canary.12 Upgrade upload-artifact action v11.1.3-canary.11 v11.1.3-canary.10 Update precompiled with-stitches example fixes vercel#28650 (vercel#28652) (docs) Add `permanent` property in redirect object (vercel#28852) (docs) Remove duplicate comma (vercel#28850) v11.1.3-canary.9
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The with-stitches example is broken presumably due to changes in the Stitches API now that it's hit
1.0.0. I've created an issue already: #28650I've made three small changes:
stitcheds.config.jswith createStitchesstitches.config.jsandpages/_documents.jsx@stitches/reactto^1.0.0🎉I've left the rest of the example code alone as I'm still exploring the library after seeing yesterdays release annoucement.
@peduarte Is there anything else that needs to updated?