-
Notifications
You must be signed in to change notification settings - Fork 26.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated webpack conformance experiment #28846
Remove outdated webpack conformance experiment #28846
Conversation
Stats from current PRDefault Build (Decrease detected ✓)General Overall decrease ✓
Page Load Tests Overall decrease
|
vercel/next.js canary | timneutkens/next.js fix/remove-unused-conformanceplugin | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.064 | 3.138 | |
/ avg req/sec | 815.9 | 796.81 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.83 | 1.838 | |
/error-in-render avg req/sec | 1366.14 | 1360.42 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/remove-unused-conformanceplugin | Change | |
---|---|---|---|
745.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 23.3 kB | 23.3 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 67.2 kB | 67.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/remove-unused-conformanceplugin | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/remove-unused-conformanceplugin | Change | |
---|---|---|---|
_app-HASH.js gzip | 979 B | 979 B | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 329 B | 329 B | ✓ |
dynamic-HASH.js gzip | 2.67 kB | 2.67 kB | ✓ |
head-HASH.js gzip | 351 B | 351 B | ✓ |
hooks-HASH.js gzip | 918 B | 918 B | ✓ |
image-HASH.js gzip | 4.14 kB | 4.14 kB | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 318 B | 318 B | ✓ |
script-HASH.js gzip | 387 B | 387 B | ✓ |
withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 13 kB | 13 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/remove-unused-conformanceplugin | Change | |
---|---|---|---|
_buildManifest.js gzip | 492 B | 492 B | ✓ |
Overall change | 492 B | 492 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js fix/remove-unused-conformanceplugin | Change | |
---|---|---|---|
index.html gzip | 539 B | 539 B | ✓ |
link.html gzip | 553 B | 553 B | ✓ |
withRouter.html gzip | 533 B | 533 B | ✓ |
Overall change | 1.63 kB | 1.63 kB | ✓ |
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | timneutkens/next.js fix/remove-unused-conformanceplugin | Change | |
---|---|---|---|
buildDuration | 12.4s | 12.4s | -31ms |
buildDurationCached | 5.1s | 5s | -134ms |
nodeModulesSize | 49.2 MB | 49.2 MB | -67.2 kB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | timneutkens/next.js fix/remove-unused-conformanceplugin | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.216 | 3.183 | -0.03 |
/ avg req/sec | 777.25 | 785.48 | +8.23 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.86 | 1.884 | |
/error-in-render avg req/sec | 1344.4 | 1326.96 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/remove-unused-conformanceplugin | Change | |
---|---|---|---|
16.HASH.js gzip | 186 B | 186 B | ✓ |
677f882d2ed8..HASH.js gzip | 14.1 kB | 14.1 kB | ✓ |
framework.HASH.js gzip | 41.9 kB | 41.9 kB | ✓ |
main-HASH.js gzip | 10.7 kB | 10.7 kB | ✓ |
webpack-HASH.js gzip | 1.19 kB | 1.19 kB | ✓ |
Overall change | 68.1 kB | 68.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/remove-unused-conformanceplugin | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/remove-unused-conformanceplugin | Change | |
---|---|---|---|
_app-HASH.js gzip | 964 B | 964 B | ✓ |
_error-HASH.js gzip | 3.8 kB | 3.8 kB | ✓ |
amp-HASH.js gzip | 552 B | 552 B | ✓ |
css-HASH.js gzip | 333 B | 333 B | ✓ |
dynamic-HASH.js gzip | 2.87 kB | 2.87 kB | ✓ |
head-HASH.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks-HASH.js gzip | 924 B | 924 B | ✓ |
index-HASH.js gzip | 231 B | 231 B | ✓ |
link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..HASH.js gzip | 298 B | 298 B | ✓ |
script-HASH.js gzip | 3.03 kB | 3.03 kB | ✓ |
withRouter-HASH.js gzip | 295 B | 295 B | ✓ |
30809af5c834..565.css gzip | 125 B | 125 B | ✓ |
Overall change | 18.1 kB | 18.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/remove-unused-conformanceplugin | Change | |
---|---|---|---|
_buildManifest.js gzip | 500 B | 500 B | ✓ |
Overall change | 500 B | 500 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js fix/remove-unused-conformanceplugin | Change | |
---|---|---|---|
index.html gzip | 584 B | 584 B | ✓ |
link.html gzip | 597 B | 597 B | ✓ |
withRouter.html gzip | 577 B | 577 B | ✓ |
Overall change | 1.76 kB | 1.76 kB | ✓ |
Failing test suitesCommit: 52d0321 test/integration/required-server-files/test/index.test.js
Expand output● Required Server Files › should output required-server-files manifest correctly
● Required Server Files › should render SSR page correctly
● Required Server Files › should render dynamic SSR page correctly
● Required Server Files › should render fallback page correctly
● Required Server Files › should render SSR page correctly with x-matched-path
● Required Server Files › should render dynamic SSR page correctly with x-matched-path
● Required Server Files › should render fallback page correctly with x-matched-path and routes-matches
● Required Server Files › should return data correctly with x-matched-path
● Required Server Files › should render fallback optional catch-all route correctly with x-matched-path and routes-matches
● Required Server Files › should return data correctly with x-matched-path for optional catch-all route
● Required Server Files › should not apply trailingSlash redirect
● Required Server Files › should normalize catch-all rewrite query values correctly
● Required Server Files › should bubble error correctly for gip page
● Required Server Files › should bubble error correctly for gssp page
● Required Server Files › should bubble error correctly for gsp page
● Required Server Files › should bubble error correctly for API page
● Required Server Files › should normalize optional values correctly for SSP page
● Required Server Files › should normalize optional values correctly for SSG page
● Required Server Files › should normalize optional values correctly for SSG page with encoded slash
● Required Server Files › should normalize optional values correctly for API page
● Required Server Files › should match the index page correctly
● Required Server Files › should match the root dyanmic page correctly
|
* canary: Remove unused profiler (vercel#28844) Remove outdated webpack conformance experiment (vercel#28846) v11.1.3-canary.13 v11.1.3-canary.12 Upgrade upload-artifact action v11.1.3-canary.11 v11.1.3-canary.10 Update precompiled with-stitches example fixes vercel#28650 (vercel#28652) (docs) Add `permanent` property in redirect object (vercel#28852) (docs) Remove duplicate comma (vercel#28850) v11.1.3-canary.9
Smaller version of #27619.
Once this has landed there's a few more things to do to have parity with #27619:
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples