Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure build trace is correct with extra entries #28667

Merged
merged 5 commits into from
Sep 1, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 31, 2021

This ensures we trace additional entry items correctly as currently it causes the traces lookup to fail.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #25431 (comment)

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Sep 1, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
buildDuration 16.4s 16.3s -46ms
buildDurationCached 3.7s 3.7s -57ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +2.53 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
/ failed reqs 0 0
/ total time (seconds) 3.104 2.952 -0.15
/ avg req/sec 805.44 846.97 +41.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.926 1.927 0
/error-in-render avg req/sec 1298.26 1297.5 ⚠️ -0.76
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
index.html gzip 540 B 540 B
link.html gzip 552 B 552 B
withRouter.html gzip 533 B 533 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
buildDuration 13.2s 13.1s -176ms
buildDurationCached 5.6s 5.6s ⚠️ +62ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +2.53 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
/ failed reqs 0 0
/ total time (seconds) 3.07 3.025 -0.04
/ avg req/sec 814.43 826.56 +12.13
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.843 1.862 ⚠️ +0.02
/error-in-render avg req/sec 1356.33 1342.7 ⚠️ -13.63
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.7 kB 10.7 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68.1 kB 68.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/build-trace-extra-entry Change
index.html gzip 586 B 586 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 260b8bc

@ijjk
Copy link
Member Author

ijjk commented Sep 1, 2021

Failing test suites

Commit: 260b8bc

test/integration/gssp-ssr-change-reloading/test/index.test.js

  • GS(S)P Server-Side Change Reloading > should not reload page when client-side is changed too GSP
  • GS(S)P Server-Side Change Reloading > should update page when getStaticProps is changed only for /index
Expand output

● GS(S)P Server-Side Change Reloading › should not reload page when client-side is changed too GSP

Failed to replace content.

Pattern: change me

Content: import { useRouter } from 'next/router'

export default function Gsp(props) {
  if (useRouter().isFallback) {
    return 'Loading...'
  }

  return (
    <>
      <p id="change">changed</p>
      <p id="props">{JSON.stringify(props)}</p>
    </>
  )
}

export const getStaticProps = async ({ params }) => {
  const count = 1

  if (params.post === 'second') {
    await new Promise((resolve) => setTimeout(resolve, 2000))
  }

  return {
    props: {
      count,
      params,
      random: Math.random(),
    },
  }
}

export const getStaticPaths = () => {
  /* eslint-disable-next-line no-unused-vars */
  const paths = 1

  return {
    paths: [{ params: { post: 'first' } }, { params: { post: 'second' } }],
    fallback: true,
  }
}

  461 |     }
  462 |
> 463 |     const newContent = currentContent.replace(pattern, newValue)
      |                       ^
  464 |     this.write(newContent)
  465 |   }
  466 |

  at File1.replace (lib/next-test-utils.js:463:23)
  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:39:14)

● GS(S)P Server-Side Change Reloading › should update page when getStaticProps is changed only for /index

SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)

   98 |     await check(
   99 |       async () =>
> 100 |         JSON.parse(await browser.elementByCss('#props').text()).count + '',
      |                            ^
  101 |       '1'
  102 |     )
  103 |   })

  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:100:28)

@ijjk ijjk merged commit 9a6542b into vercel:canary Sep 1, 2021
@ijjk ijjk deleted the fix/build-trace-extra-entry branch September 1, 2021 15:56
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack 5, API functions and Vercel error
2 participants