Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused dependencies #28876

Merged
merged 3 commits into from
Sep 7, 2021
Merged

Remove unused dependencies #28876

merged 3 commits into from
Sep 7, 2021

Conversation

timneutkens
Copy link
Member

  • Remove recast
  • Remove ast-types dependency

Follow up to #28846

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Sep 7, 2021
@ijjk
Copy link
Member

ijjk commented Sep 7, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
buildDuration 15.3s 14.1s -1.1s
buildDurationCached 3.8s 3.9s ⚠️ +116ms
nodeModulesSize 49 MB 48.2 MB -827 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.05 2.937 -0.11
/ avg req/sec 819.67 851.33 +31.66
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.813 1.763 -0.05
/error-in-render avg req/sec 1378.68 1418.33 +39.65
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
745.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 23.3 kB 23.3 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 67.2 kB 67.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
_app-HASH.js gzip 979 B 979 B ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 329 B 329 B ✓
dynamic-HASH.js gzip 2.67 kB 2.67 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 918 B 918 B ✓
image-HASH.js gzip 4.14 kB 4.14 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 318 B 318 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 13 kB 13 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
_buildManifest.js gzip 492 B 492 B ✓
Overall change 492 B 492 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
index.html gzip 541 B 541 B ✓
link.html gzip 553 B 553 B ✓
withRouter.html gzip 534 B 534 B ✓
Overall change 1.63 kB 1.63 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
buildDuration 11.8s 12.1s ⚠️ +330ms
buildDurationCached 5s 4.9s -32ms
nodeModulesSize 49 MB 48.2 MB -827 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.043 3.049 ⚠️ +0.01
/ avg req/sec 821.44 819.91 ⚠️ -1.53
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.825 1.872 ⚠️ +0.05
/error-in-render avg req/sec 1370.04 1335.17 ⚠️ -34.87
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
16.HASH.js gzip 186 B 186 B ✓
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB ✓
framework.HASH.js gzip 41.9 kB 41.9 kB ✓
main-HASH.js gzip 10.7 kB 10.7 kB ✓
webpack-HASH.js gzip 1.19 kB 1.19 kB ✓
Overall change 68.1 kB 68.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
_app-HASH.js gzip 964 B 964 B ✓
_error-HASH.js gzip 3.8 kB 3.8 kB ✓
amp-HASH.js gzip 552 B 552 B ✓
css-HASH.js gzip 333 B 333 B ✓
dynamic-HASH.js gzip 2.87 kB 2.87 kB ✓
head-HASH.js gzip 3.06 kB 3.06 kB ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 231 B 231 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 298 B 298 B ✓
script-HASH.js gzip 3.03 kB 3.03 kB ✓
withRouter-HASH.js gzip 295 B 295 B ✓
30809af5c834..565.css gzip 125 B 125 B ✓
Overall change 18.1 kB 18.1 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
_buildManifest.js gzip 500 B 500 B ✓
Overall change 500 B 500 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/remove-unused-deps Change
index.html gzip 585 B 585 B ✓
link.html gzip 596 B 596 B ✓
withRouter.html gzip 577 B 577 B ✓
Overall change 1.76 kB 1.76 kB ✓
Commit: 1cb08b2

@timneutkens timneutkens merged commit 7266d75 into vercel:canary Sep 7, 2021
@timneutkens timneutkens deleted the fix/remove-unused-deps branch September 7, 2021 13:36
bordeo pushed a commit to filoblu/next.js that referenced this pull request Sep 8, 2021
Merge branch 'canary' into feature/symlink-pages
37c7f1c 
* canary:
  v11.1.3-canary.14
  Ensure timed out prefetches are cleaned up correctly (vercel#28899)
  Fix/swc minify (vercel#28898)
  Update concurrent tests and enable experimental streaming (vercel#28892)
  Fix Typo in "with-eslint" Example docs (vercel#28601)
  Examples Prepr CMS update (vercel#28871)
  fixes with-typescript-graphql: unable to resolve dependency tree (vercel#28637)
  Update `next/link` API docs to mention a11y and ESLint rule. (vercel#28841)
  Trim large test output to not exceed limit (vercel#28881)
  Updates @react-three/drei version and other dependencies. (vercel#28755)
  Remove unused dependencies (vercel#28876)
JuanM04 added a commit to blitz-js/blitz that referenced this pull request Nov 3, 2021
@JuanM04
Fixed dependencies
617f9d7 
Upgraded next.js ast-types, but it doesn't matter because it was removed
in a newer version: vercel/next.js#28876

Fixed @mrleebo/prisma-ast in 0.2.4 until this PR gets merged: MrLeebo/prisma-ast#3
@JuanM04 JuanM04 mentioned this pull request Nov 4, 2021
Merged
2 tasks
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timneutkens @ijjk @styfle