fix(examples/cms-contentful): add correct Content-Type + missing closing tag for html #30321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfortaine
requested review from
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
gfortaine
force-pushed
the
bugfix/fix-example-cms-contentful
branch
from
4cc4438
to
777cb6e
Compare
gfortaine
force-pushed
the
bugfix/fix-example-cms-contentful
branch
from
9e99be1
to
c829474
Compare
|
Could you share more about this issue? |
|
This PR tries to fix 2 issues with the current implementation of api/preview : • missing content-type for response • missing html closing tag Indeed, we have encountered these bugs by copy-pasting the example |
gfortaine
force-pushed
the
bugfix/fix-example-cms-contentful
branch
from
d882975
to
7d6a3e4
Compare
gfortaine
force-pushed
the
bugfix/fix-example-cms-contentful
branch
from
7d6a3e4
to
90d3b1d
Compare
teleaziz
added a commit
to teleaziz/next.js
that referenced
this pull request
Jan 5, 2022
…o-example * 'canary' of github.com:vercel/next.js: [chore] Update `deta` version in examples (vercel#30204) fix: typescript example supporting strict w/ version >= 4.4 (vercel#33042) Avoid page double render with emotion vanilla (vercel#30541) converted the old tailwind css example to typescript (vercel#32808) fix(examples/cms-contentful): add correct Content-Type + missing closing tag for html (vercel#30321) Ensure NODE_ENV is not inlined for next/jest (vercel#33032) Rename api in with-redis example (vercel#33016) Remove unused turbo remote cache env vars (vercel#33030) v12.0.8-canary.17 Re-enable turbo caching for swc build jobs (vercel#32617) feat(cli): introduce `next info` CLI command (vercel#32972) fix(examples): add missing dependencies wo (vercel#32977) Updated wrong link to example of gtag init in measuring-performance.md (vercel#32974) v12.0.8-canary.16 Revert "Reduce install size for linux glibc/musl (vercel#32850)" (vercel#32973) Ensure middleware is output in standalone mode (vercel#32967) v12.0.8-canary.15 Reduce install size for linux glibc/musl (vercel#32850) Fixes issue with makeStylesheetInert (vercel#32027) Ensure setImmediate and punycode are polyfilled (vercel#32768)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples
yarn lint