Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable turbo caching for swc build jobs #32617

Merged
merged 17 commits into from
Jan 4, 2022
Merged

Re-enable turbo caching for swc build jobs #32617

merged 17 commits into from
Jan 4, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 17, 2021 •
edited

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Dec 17, 2021
@ijjk ijjk mentioned this pull request Dec 17, 2021
Merged
@ijjk ijjk requested a review from padmaia December 17, 2021 23:45
@ijjk ijjk changed the title Fix build-native jobs Re-enable turbo caching for swc build jobs Jan 4, 2022
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk marked this pull request as ready for review January 4, 2022 20:09
@ijjk
Copy link
Member Author

ijjk commented Jan 4, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js fix/native-builds Change
buildDuration 18.4s 18.8s ⚠️ +425ms
buildDurationCached 4.1s 4.2s ⚠️ +76ms
nodeModulesSize 348 MB 348 MB -15 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix/native-builds Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.974 4.018 ⚠️ +0.04
/ avg req/sec 629.03 622.27 ⚠️ -6.76
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.129 2.094 -0.04
/error-in-render avg req/sec 1174.16 1193.82 +19.66
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/native-builds Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.1 kB 27.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.9 kB 70.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/native-builds Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix/native-builds Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.74 kB 4.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix/native-builds Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/native-builds Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js fix/native-builds Change
buildDuration 21s 20.7s -216ms
buildDurationCached 4.2s 4.1s -48ms
nodeModulesSize 348 MB 348 MB -15 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix/native-builds Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.997 3.946 -0.05
/ avg req/sec 625.45 633.58 +8.13
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.169 2.183 ⚠️ +0.01
/error-in-render avg req/sec 1152.55 1145 ⚠️ -7.55
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/native-builds Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/native-builds Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix/native-builds Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.76 kB 4.76 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix/native-builds Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/native-builds Change
index.html gzip 531 B 531 B ✓
link.html gzip 543 B 543 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 74aa826

@ijjk ijjk merged commit 5e5f1df into canary Jan 4, 2022
@ijjk ijjk deleted the fix/native-builds branch January 4, 2022 21:10
@jaredpalmer jaredpalmer mentioned this pull request Jan 5, 2022
Merged
teleaziz added a commit to teleaziz/next.js that referenced this pull request Jan 5, 2022
@teleaziz
Merge branch 'canary' of github.com:vercel/next.js into cms-builder-i…
c9fadc8 
…o-example

* 'canary' of github.com:vercel/next.js:
  [chore] Update `deta` version in examples (vercel#30204)
  fix: typescript example supporting strict w/ version >= 4.4 (vercel#33042)
  Avoid page double render with emotion vanilla (vercel#30541)
  converted the old tailwind css example to typescript  (vercel#32808)
  fix(examples/cms-contentful): add correct Content-Type + missing closing tag for html (vercel#30321)
  Ensure NODE_ENV is not inlined for next/jest (vercel#33032)
  Rename api in with-redis example (vercel#33016)
  Remove unused turbo remote cache env vars (vercel#33030)
  v12.0.8-canary.17
  Re-enable turbo caching for swc build jobs (vercel#32617)
  feat(cli): introduce `next info` CLI command (vercel#32972)
  fix(examples): add missing dependencies wo (vercel#32977)
  Updated wrong link to example of gtag init in measuring-performance.md (vercel#32974)
  v12.0.8-canary.16
  Revert "Reduce install size for linux glibc/musl (vercel#32850)" (vercel#32973)
  Ensure middleware is output in standalone mode (vercel#32967)
  v12.0.8-canary.15
  Reduce install size for linux glibc/musl (vercel#32850)
  Fixes issue with makeStylesheetInert (vercel#32027)
  Ensure setImmediate and punycode are polyfilled (vercel#32768)
@vercel vercel locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@padmaia padmaia Awaiting requested review from padmaia

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @styfle @jaredpalmer