Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue with makeStylesheetInert #32027

Merged
merged 7 commits into from
Jan 3, 2022
Merged

Fixes issue with makeStylesheetInert #32027

merged 7 commits into from
Jan 3, 2022

Conversation

dm430
Copy link
Contributor

@dm430 dm430 commented Dec 2, 2021 •
edited

Fixes #32024

Fixing makeStylesheetInert.
Fixes log import.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@DevinWallKcl
Fixing log import.
d065354 
Fixing makeStylesheetInert.
@ijjk ijjk added the type: next label Dec 2, 2021
@dm430 dm430 changed the title Fixing log import. Fixes issue with makeStylesheetInert Dec 2, 2021
ijjk
ijjk requested changes Dec 16, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you add a test for this to ensure we don't regress on this? We could potentially add this case to the _document in the font-optimization test here

@DevinWallKcl
Copy link
Contributor

Hi, could you add a test for this to ensure we don't regress on this? We could potentially add this case to the _document in the font-optimization test here

I can take a look at adding something tomorrow if I get some time. If not then I will have some time to address this over the weekend.

@DevinWallKcl
Copy link
Contributor

@ijjk Ive added a regression test. Let me know if you need anything else, or need me to change anything about the test.

ijjk
ijjk approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Jan 3, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
buildDuration 14s 14.1s ⚠️ +147ms
buildDurationCached 3.2s 3.2s -17ms
nodeModulesSize 348 MB 348 MB ⚠️ +1.26 kB
Page Load Tests Overall increase ✓
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.873 2.888 ⚠️ +0.01
/ avg req/sec 870.07 865.58 ⚠️ -4.49
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.338 1.315 -0.02
/error-in-render avg req/sec 1867.8 1900.65 +32.85
Client Bundles (main, webpack, commons)
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.1 kB 27.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.9 kB 70.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.74 kB 4.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC
General Overall increase ⚠️
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
buildDuration 15.5s 15.5s -6ms
buildDurationCached 3.2s 3.2s ⚠️ +31ms
nodeModulesSize 348 MB 348 MB ⚠️ +1.26 kB
Page Load Tests Overall increase ✓
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.916 2.901 -0.02
/ avg req/sec 857.27 861.81 +4.54
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.343 1.346 0
/error-in-render avg req/sec 1861.37 1858.04 ⚠️ -3.33
Client Bundles (main, webpack, commons)
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.76 kB 4.76 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary dm430/next.js dm430/fix-32024 Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 7d83222

@kodiakhq kodiakhq bot merged commit d0e72fd into vercel:canary Jan 3, 2022
teleaziz added a commit to teleaziz/next.js that referenced this pull request Jan 5, 2022
@teleaziz
Merge branch 'canary' of github.com:vercel/next.js into cms-builder-i…
c9fadc8 
…o-example

* 'canary' of github.com:vercel/next.js:
  [chore] Update `deta` version in examples (vercel#30204)
  fix: typescript example supporting strict w/ version >= 4.4 (vercel#33042)
  Avoid page double render with emotion vanilla (vercel#30541)
  converted the old tailwind css example to typescript  (vercel#32808)
  fix(examples/cms-contentful): add correct Content-Type + missing closing tag for html (vercel#30321)
  Ensure NODE_ENV is not inlined for next/jest (vercel#33032)
  Rename api in with-redis example (vercel#33016)
  Remove unused turbo remote cache env vars (vercel#33030)
  v12.0.8-canary.17
  Re-enable turbo caching for swc build jobs (vercel#32617)
  feat(cli): introduce `next info` CLI command (vercel#32972)
  fix(examples): add missing dependencies wo (vercel#32977)
  Updated wrong link to example of gtag init in measuring-performance.md (vercel#32974)
  v12.0.8-canary.16
  Revert "Reduce install size for linux glibc/musl (vercel#32850)" (vercel#32973)
  Ensure middleware is output in standalone mode (vercel#32967)
  v12.0.8-canary.15
  Reduce install size for linux glibc/musl (vercel#32850)
  Fixes issue with makeStylesheetInert (vercel#32027)
  Ensure setImmediate and punycode are polyfilled (vercel#32768)
@vercel vercel locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Font optimization can result in error: "TypeError: Cannot read property 'type' of null"
3 participants
@dm430 @DevinWallKcl @ijjk