Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NextServer runtime agnostic #31971

Closed
wants to merge 4 commits into from
Closed

Conversation

shuding
Copy link
Member

@shuding shuding commented Nov 30, 2021

As an important step for #31506, this PR adds a WebServer class similar to DevServer, overriding methods from the default server that depends on native APIs.

  • fs
  • require
  • manifests

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Nov 30, 2021
@karaggeorge karaggeorge mentioned this pull request Dec 2, 2021
This was referenced Dec 2, 2021
@shuding shuding closed this Jan 15, 2022
@shuding shuding deleted the shu/62b0 branch January 15, 2022 00:14
@vercel vercel locked as resolved and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants