Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve full refresh overlay #33301

Merged
merged 3 commits into from Jan 14, 2022
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 14, 2022

include a few lines of stack trace in the full refresh overlay
error is not necessary webpack related

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

include a few lines of stack trace in the full refresh overlay
error is not necessary webpack related
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jan 14, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
buildDuration 14s 13.9s -148ms
buildDurationCached 3.1s 3.2s ⚠️ +21ms
nodeModulesSize 355 MB 355 MB ⚠️ +309 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
/ failed reqs 0 0
/ total time (seconds) 2.84 2.848 ⚠️ +0.01
/ avg req/sec 880.32 877.68 ⚠️ -2.64
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.276 1.256 -0.02
/error-in-render avg req/sec 1959.51 1990.85 +31.34
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.7 kB 4.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
buildDuration 15.4s 15.5s ⚠️ +91ms
buildDurationCached 3.2s 3.2s -18ms
nodeModulesSize 355 MB 355 MB ⚠️ +309 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
/ failed reqs 0 0
/ total time (seconds) 2.884 2.905 ⚠️ +0.02
/ avg req/sec 866.85 860.49 ⚠️ -6.36
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.283 1.328 ⚠️ +0.05
/error-in-render avg req/sec 1948.45 1882.8 ⚠️ -65.65
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js dx/include-stack-in-full-refresh-warning Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 0ea8ba6

@kodiakhq kodiakhq bot merged commit 30ca6b3 into canary Jan 14, 2022
41 of 43 checks passed
@kodiakhq kodiakhq bot deleted the dx/include-stack-in-full-refresh-warning branch Jan 14, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants