Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added with-particles template #35471

Merged
merged 17 commits into from
Jun 22, 2022
Merged

Added with-particles template #35471

merged 17 commits into from
Jun 22, 2022

Conversation

matteobruni
Copy link
Contributor

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label Mar 20, 2022
matteobruni and others added 4 commits May 9, 2022 12:46
Co-authored-by: Balázs Orbán <info@balazsorban.com>
Co-authored-by: Balázs Orbán <info@balazsorban.com>
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added some small comments.

Another question, what's the correct way of referring to the library? I see the directory was named with-particles, but the package is called react-tsparticles, the website https://particles.js.org/ says "TS Particles" (while the page title is tsParticles).

The reason I'm asking is that there is a https://vincentgarreau.com/particles.js/ so to not confuse developers, maybe we should call the directory with-tsparticles? What do you think?

examples/with-particles/pages/api/hello.js Outdated Show resolved Hide resolved
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my comments, could we also convert this example to TypeScript?

@matteobruni
Copy link
Contributor Author

matteobruni commented May 10, 2022

Thanks for fixing my comments, could we also convert this example to TypeScript?

@balazsorban44 Another example or just convert this one to TS? It's not a problem either way

@balazsorban44
Copy link
Member

Converting this to TypeScript should be enough. 👍

@matteobruni
Copy link
Contributor Author

Converting this to TypeScript should be enough. 👍

Converted 👍

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit cf3ba27 into vercel:canary Jun 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants