Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(#41392): improve cache busting inject performance #41443

Merged
merged 4 commits into from
Oct 15, 2022
Merged

perf(#41392): improve cache busting inject performance #41443

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a9beaa
perf(#41392): improve cache busting inject performance
SukkaW Oct 15, 2022
d0a0366
Merge branch 'canary' into perf-css-cache-busting
kodiakhq[bot] Oct 15, 2022
623e217
Merge branch 'canary' into perf-css-cache-busting
ijjk Oct 15, 2022
664a9ff
Merge branch 'canary' into perf-css-cache-busting
kodiakhq[bot] Oct 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/next/server/app-render.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,6 +1165,10 @@ export async function renderToHTMLOrFlight(
Component: () => {
let props = {}

// Add extra cache busting (DEV only) for https://github.com/vercel/next.js/issues/5860
// See also https://bugs.webkit.org/show_bug.cgi?id=187726
const cacheBustingUrlSuffix = dev ? `?ts=${Date.now()}` : ''

return (
<>
{preloadedFontFiles.map((fontFile) => {
Expand All @@ -1184,9 +1188,7 @@ export async function renderToHTMLOrFlight(
? stylesheets.map((href) => (
<link
rel="stylesheet"
// Add extra cache busting (DEV only) for https://github.com/vercel/next.js/issues/5860
// See also https://bugs.webkit.org/show_bug.cgi?id=187726
href={`/_next/${href}${dev ? `?ts=${Date.now()}` : ''}`}
href={`/_next/${href}${cacheBustingUrlSuffix}`}
// `Precedence` is an opt-in signal for React to handle
// resource loading and deduplication, etc:
// https://github.com/facebook/react/pull/25060
Expand Down