Webpack 2 #449
Merged
Webpack 2 #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rauchg
reviewed
Dec 21, 2016
| 'babelrc': false, | ||
| 'presets': [ | ||
| loader: 'babel-loader', | ||
| options: { |
There was a problem hiding this comment.
here we could decorate this with options.babel() to make it easier to config babel for next?
There was a problem hiding this comment.
Can you elaborate options.babel() ?
|
It seems this is a blocker for v2 release. I will add the monkey-patch if needed. |
|
Yep. That's seems like the best way to do it. |
|
fce9f02 is the monkeypatch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades webpack to v2.
btw It looks our blocker (webpack/watchpack#33) is going to be published soon.https://github.com/webpack/watchpack/releases/tag/v1.1.2 (not released to npm yet)It seems the tag was removed. I don't know the current status of it.