Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wasm target #57437

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Remove wasm target #57437

merged 6 commits into from
Oct 26, 2023

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Oct 25, 2023

This PR removes the wasm target for the next-swc build for the next major version. The main motivation is that Turbopack does not support targeting wasm yet, and it would be a significant amount of work to add. We plan to make Turbopack the default zero-config experience in a minor version, possibly before we are able to support a wasm target, so we need to make this breaking change now. We also plan to make more improvements to the webpack experience with shared Rust code, which we have so far been blocked from implementing because of the current wasm restrictions. We would like to support a wasm target again in the future, but cannot say at this time when that would be.

Closes WEB-1865

@padmaia padmaia requested review from manovotny and leerob and removed request for a team October 25, 2023 18:38
timneutkens
timneutkens previously approved these changes Oct 25, 2023
kdy1
kdy1 previously approved these changes Oct 25, 2023
@padmaia padmaia dismissed stale reviews from kdy1 and timneutkens via 7a36888 October 25, 2023 19:58
timneutkens
timneutkens previously approved these changes Oct 25, 2023
huozhi
huozhi previously approved these changes Oct 25, 2023
@ijjk
Copy link
Member

ijjk commented Oct 25, 2023

Stats from current PR

Default Build
General
vercel/next.js canary padmaia/next.js remove-wasm-target Change
buildDuration 10.1s 10.3s ⚠️ +161ms
buildDurationCached 6s 6s N/A
nodeModulesSize 175 MB 175 MB N/A
nextStartRea..uration (ms) 419ms 415ms N/A
Client Bundles (main, webpack)
vercel/next.js canary padmaia/next.js remove-wasm-target Change
199-HASH.js gzip 32.3 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 253 B 252 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js remove-wasm-target Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js remove-wasm-target Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js remove-wasm-target Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js remove-wasm-target Change
index.html gzip 529 B 530 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 523 B 523 B
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary padmaia/next.js remove-wasm-target Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary padmaia/next.js remove-wasm-target Change
middleware-b..fest.js gzip 625 B 622 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.6 kB 25.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: e846636

@padmaia padmaia dismissed stale reviews from huozhi and timneutkens via 9133e89 October 25, 2023 23:29
@kodiakhq kodiakhq bot merged commit f412c8a into vercel:canary Oct 26, 2023
51 of 56 checks passed
padmaia added a commit to padmaia/next.js that referenced this pull request Nov 1, 2023
@padmaia padmaia mentioned this pull request Nov 1, 2023
kwonoj pushed a commit that referenced this pull request Nov 1, 2023
kwonoj pushed a commit that referenced this pull request Nov 2, 2023
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants