Skip packing compression in tests #57671
Open
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankaifer
requested review from
ismaelrumzan and
StephDietz
and removed request for
a team
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
2 similar comments
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that you guys updated to
pnpm@8, which means you are able to use this flag that I added intopnpmwhen I was digging into next speed improvements.Especially when running in
devmove the longest thing is packing our packages that are later installed in the isolated test environment. It can be sped up by a lot if you skip the compression because we don't care about the sizes in our tests.You can see the speed improvement by running test tracing:
When I measured the impact half-year ago it should speed up each test run by ~4 seconds.
I tried to do this myself, but I was not able to get the test suite to run (even on
canary).Also testing doc is outdated, the example commands use non-existent tests.
The issue was that
next buildrunning in the test got stuck and never finished.