-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use 303 status code for redirects in fetch actions #59017
Merged
ztanner
merged 2 commits into
canary
from
11-28-use_303_status_code_for_redirects_in_fetch_actions
Nov 29, 2023
Merged
use 303 status code for redirects in fetch actions #59017
ztanner
merged 2 commits into
canary
from
11-28-use_303_status_code_for_redirects_in_fetch_actions
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
area: tests
created-by: Next.js team
PRs by the Next.js team.
type: next
labels
Nov 28, 2023
This was referenced Nov 28, 2023
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Stats from current PRDefault BuildGeneral Overall increase
|
vercel/next.js canary | vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions | Change | |
---|---|---|---|
buildDuration | 10.2s | 10.2s | N/A |
buildDurationCached | 5.9s | 6s | N/A |
nodeModulesSize | 199 MB | 199 MB | |
nextStartRea..uration (ms) | 427ms | 420ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions | Change | |
---|---|---|---|
199-HASH.js gzip | 30.7 kB | 30.7 kB | N/A |
3f784ff6-HASH.js gzip | 53.3 kB | 53.3 kB | ✓ |
494.HASH.js gzip | 180 B | 181 B | N/A |
framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
main-app-HASH.js gzip | 241 B | 240 B | N/A |
main-HASH.js gzip | 31.7 kB | 31.7 kB | N/A |
webpack-HASH.js gzip | 1.7 kB | 1.7 kB | ✓ |
Overall change | 100 kB | 100 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions | Change | |
---|---|---|---|
_app-HASH.js gzip | 194 B | 195 B | N/A |
_error-HASH.js gzip | 182 B | 181 B | N/A |
amp-HASH.js gzip | 501 B | 503 B | N/A |
css-HASH.js gzip | 322 B | 323 B | N/A |
dynamic-HASH.js gzip | 2.5 kB | 2.5 kB | ✓ |
edge-ssr-HASH.js gzip | 253 B | 255 B | N/A |
head-HASH.js gzip | 348 B | 347 B | N/A |
hooks-HASH.js gzip | 369 B | 368 B | N/A |
image-HASH.js gzip | 4.27 kB | 4.27 kB | N/A |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.61 kB | 2.6 kB | N/A |
routerDirect..HASH.js gzip | 311 B | 311 B | ✓ |
script-HASH.js gzip | 384 B | 383 B | N/A |
withRouter-HASH.js gzip | 307 B | 308 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.17 kB | 3.17 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions | Change | |
---|---|---|---|
_buildManifest.js gzip | 484 B | 483 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions | Change | |
---|---|---|---|
index.html gzip | 529 B | 527 B | N/A |
link.html gzip | 540 B | 540 B | ✓ |
withRouter.html gzip | 525 B | 523 B | N/A |
Overall change | 540 B | 540 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions | Change | |
---|---|---|---|
edge-ssr.js gzip | 92.6 kB | 92.6 kB | N/A |
page.js gzip | 145 kB | 145 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 624 B | 624 B | ✓ |
middleware-r..fest.js gzip | 150 B | 151 B | N/A |
middleware.js gzip | 35.7 kB | 35.7 kB | ✓ |
edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
Overall change | 38.3 kB | 38.3 kB | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 168 kB | 168 kB | ✓ |
app-page-exp..prod.js gzip | 93.6 kB | 93.6 kB | ✓ |
app-page-tur..prod.js gzip | 94.4 kB | 94.4 kB | N/A |
app-page-tur..prod.js gzip | 88.9 kB | 88.9 kB | ✓ |
app-page.run...dev.js gzip | 138 kB | 138 kB | ✓ |
app-page.run..prod.js gzip | 88.3 kB | 88.3 kB | ✓ |
app-route-ex...dev.js gzip | 24.2 kB | 24.2 kB | ✓ |
app-route-ex..prod.js gzip | 16.8 kB | 16.8 kB | ✓ |
app-route-tu..prod.js gzip | 16.9 kB | 16.9 kB | ✓ |
app-route-tu..prod.js gzip | 16.4 kB | 16.4 kB | ✓ |
app-route.ru...dev.js gzip | 23.6 kB | 23.6 kB | ✓ |
app-route.ru..prod.js gzip | 16.4 kB | 16.4 kB | ✓ |
pages-api-tu..prod.js gzip | 9.37 kB | 9.37 kB | ✓ |
pages-api.ru...dev.js gzip | 9.64 kB | 9.64 kB | ✓ |
pages-api.ru..prod.js gzip | 9.37 kB | 9.37 kB | ✓ |
pages-turbo...prod.js gzip | 21.9 kB | 21.9 kB | ✓ |
pages.runtim...dev.js gzip | 22.6 kB | 22.6 kB | ✓ |
pages.runtim..prod.js gzip | 21.9 kB | 21.9 kB | ✓ |
server.runti..prod.js gzip | 49.3 kB | 49.3 kB | ✓ |
Overall change | 835 kB | 835 kB | ✓ |
Diff details
Diff for page.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
Diff too large to display
Diff for app-page-exp..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page.runtime.dev.js
Diff too large to display
Diff for app-page.runtime.prod.js
Diff too large to display
ztanner
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim and
wyattjoh
as code owners
November 28, 2023 15:25
ztanner
force-pushed
the
11-24-update_status_codes_for_redirect_and_permanentRedirect_in_action_handlers
branch
from
November 28, 2023 15:29
7ef3827
to
1d2ab51
Compare
ztanner
requested review from
manovotny and
lydiahallie
and removed request for
a team
November 28, 2023 15:29
ztanner
force-pushed
the
11-28-use_303_status_code_for_redirects_in_fetch_actions
branch
from
November 28, 2023 15:30
77a1dca
to
a4d0781
Compare
shuding
previously approved these changes
Nov 28, 2023
Tests Passed |
Base automatically changed from
11-24-update_status_codes_for_redirect_and_permanentRedirect_in_action_handlers
to
canary
November 29, 2023 08:35
ztanner
force-pushed
the
11-28-use_303_status_code_for_redirects_in_fetch_actions
branch
from
November 29, 2023 14:55
a4d0781
to
712c28f
Compare
shuding
approved these changes
Nov 29, 2023
ztanner
deleted the
11-28-use_303_status_code_for_redirects_in_fetch_actions
branch
November 29, 2023 19:45
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A
redirect
that occurs during a fetch action will get a status code of 200, while the redirection logic is handled client-side.Why?
In this scenario, the redirect is handled by the client router, so no
Location
is set on the action response. However for debugging / logging purposes, it'd be useful to still return the same status code used in other cases (see #58885)How?
Rather than selectively setting the status to 303 in the non-fetch action case, this always applies it.
Closes NEXT-1745