-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove duplicate util file for redirect status #58878
Merged
ztanner
merged 1 commit into
canary
from
11-24-remove_duplicate_util_file_for_redirect_status
Nov 27, 2023
Merged
remove duplicate util file for redirect status #58878
ztanner
merged 1 commit into
canary
from
11-24-remove_duplicate_util_file_for_redirect_status
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
Diff detailsDiff for page.jsDiff too large to display Diff for 199-HASH.jsDiff too large to display Diff for app-page-exp..ntime.dev.jsDiff too large to display Diff for app-page.runtime.dev.jsDiff too large to display |
This was referenced Nov 24, 2023
ztanner
force-pushed
the
11-24-remove_duplicate_util_file_for_redirect_status
branch
from
November 24, 2023 19:18
56a5244
to
8b7e71a
Compare
ztanner
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim and
wyattjoh
as code owners
November 24, 2023 19:21
huozhi
approved these changes
Nov 27, 2023
ztanner
deleted the
11-24-remove_duplicate_util_file_for_redirect_status
branch
November 27, 2023 14:58
This was referenced Nov 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change in behavior, this just moves a util that performs the same error digest parsing into the other file that performs similar behavior & validation. Since splitting & parsing the digest string is a strange operation, this keeps it close to where that happens & where it's validated so it's easier to follow.
Since this file is imported in the same spots that we're importing the other redirect utils, there doesn't seem to be a reason to keep them separated.