Reset prefetchCache when reloading a route. #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunoda
changed the title
nkzawa
reviewed
Jan 2, 2017
| @@ -77,6 +78,7 @@ export default class Router extends EventEmitter { | |||
|
|
|||
| async reload (route) { | |||
| delete this.components[route] | |||
| await reloadIfPrefetched(route) | |||
There was a problem hiding this comment.
reload is called only on special cases (errors, add/remove pages). I wonder if we don't have to fix another cases (webpack's normal HMRs) too.
There was a problem hiding this comment.
We don't need to do anything for normal HMR since the page gets updated via HMR.
We need to do this, because we are removing the page from the cache and loading a error page instead.
nkzawa
reviewed
Jan 2, 2017
| return resolve() | ||
| }) | ||
| }) | ||
| } |
There was a problem hiding this comment.
I think we should have only the promise version of the method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #616
If there's a HMR reload event, we'll prefetch again if the route is registered for prefetching.