fix: Update install method for Bun #64151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaid-maker
requested review from
ismaelrumzan and
StephDietz
and removed request for
a team
I double check by upgrading my Bun and the issue is still same. |
|
Verified on a Linux Machine as well!
|
|
I read the docs they say both of these work identically might a bug in Bun idk!! Tested on Windows and Linux tho. |
|
I have update to show to use both methods... Sounds good? |
Zaid-maker
changed the title
|
@ijjk Is it good now? 😄 |
ijjk
reviewed
Apr 7, 2024
ijjk
reviewed
Apr 7, 2024
ijjk
approved these changes
Apr 7, 2024
|
Let's leave it as this as from testing against latest bun this appears to work correctly while the other doesn't, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
So, i was trying to create a Next.js project with Bun as i was experimenting with it and i got error creating the project
error: could not determine executable to run for package createso i added-after create and works and created by project successfully.Before
After