Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Google Analytics example for App Router #66021

Merged
merged 2 commits into from
May 21, 2024
Merged

Update Google Analytics example for App Router #66021

merged 2 commits into from
May 21, 2024

Conversation

qqww08
Copy link
Contributor

@qqww08 qqww08 commented May 21, 2024

Hello

This PR updates the with-google-analytics example to use:

  • App Router
  • TypeScript
  • @next/third-parties

@qqww08 qqww08 requested review from a team as code owners May 21, 2024 06:50
@qqww08 qqww08 requested review from molebox and StephDietz and removed request for a team May 21, 2024 06:50
@ijjk ijjk added the examples Issue/PR related to examples label May 21, 2024
samcx
samcx approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx enabled auto-merge (squash) May 21, 2024 20:44
@samcx samcx merged commit 16c4e47 into vercel:canary May 21, 2024
34 checks passed
@github-actions github-actions bot added the locked label Jun 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samcx samcx samcx approved these changes

@molebox molebox Awaiting requested review from molebox molebox was automatically assigned from vercel/devex

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
examples Issue/PR related to examples locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qqww08 @samcx @ijjk