Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sanity example deps and prepare for next v15 #66158

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

stipsan
Copy link
Contributor

@stipsan stipsan commented May 24, 2024

We've been testing React v19 and we're mostly ready. Since we have a number of upstream packages we have to update peer deps from:

{
  "peerDependencies": {
    "react": "^18.3",
    "react-dom": "^18.3"
  }
}

to:

{
  "peerDependencies": {
    "react": "^18.3 || ^19",
    "react-dom": "^18.3 || ^19"
  }
}

We are choosing to change the next semver from latest to ^14.2.3.
This is to avoid the template from breaking after v15 becomes latest, since package manager default behaviour doesn't handle conflicting peer dep ranges for react very well 🙌

@stipsan stipsan requested review from a team as code owners May 24, 2024 06:22
@stipsan stipsan requested review from timeyoutakeit and leerob and removed request for a team May 24, 2024 06:22
@ijjk ijjk added the examples Issue/PR related to examples label May 24, 2024
@ijjk
Copy link
Member

ijjk commented May 24, 2024

Allow CI Workflow Run

  • approve CI run for commit: 4172a82

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx merged commit df926a4 into vercel:canary Jun 4, 2024
35 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants