Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code examples in documentation (12-third-party-libraries) #66600

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

ArnaudFavier
Copy link
Contributor

@ArnaudFavier ArnaudFavier commented Jun 6, 2024

Update four code examples in 12-third-party-libraries.mdx:

  • Old not working code syntax was used to send events to Google Analytics and Google Tag Manager.

Hello, I fixed four code examples in the file `12-third-party-libraries.mdx` where an old syntax was used to send events to Google Analytics and Google Tag Manager.
@ArnaudFavier ArnaudFavier requested review from a team as code owners June 6, 2024 11:51
@ArnaudFavier ArnaudFavier requested review from ismaelrumzan and jh3y and removed request for a team June 6, 2024 11:51
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Jun 6, 2024
@ijjk
Copy link
Member

ijjk commented Jun 6, 2024

Allow CI Workflow Run

  • approve CI run for commit: dbb16a5

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ArnaudFavier ArnaudFavier changed the title Update code examples in documentation 12-third-party-libraries Update code examples in documentation (12-third-party-libraries) Jun 6, 2024
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx enabled auto-merge (squash) June 6, 2024 22:40
@samcx samcx merged commit 31222b5 into vercel:canary Jun 6, 2024
33 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants