Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix photon binary resolution #28

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Conversation

timsuchanek
Copy link
Contributor

We renamed the binary of photon from prisma to query-engine-${PLATFORM}.
In order to support that, I changed the special case to copy the whole runtime directory.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test fails

@codecov-io
Copy link

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files          10       10           
  Lines         980      980           
=======================================
  Hits          881      881           
  Misses         99       99
Impacted Files Coverage Δ
src/utils/special-cases.js 95.58% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e721bc6...52df12a. Read the comment docs.

@styfle styfle merged commit 0be5c03 into vercel:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants