Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resolution): Fix resolution of querystringed imports in ESM files #336

Closed
wants to merge 15 commits into from
Closed

fix(resolution): Fix resolution of querystringed imports in ESM files #336

wants to merge 15 commits into from

Commits on Dec 6, 2022

  1. add parseSpecifier helper

    @lobsterkatie
    lobsterkatie committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    aebf66c View commit details
    Browse the repository at this point in the history

  2. strip querystring from ESM imports in resolveDependency

    @lobsterkatie
    lobsterkatie committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    fb93620 View commit details
    Browse the repository at this point in the history

  3. pass cjsResolve to emitDependency implementation method

    @lobsterkatie
    lobsterkatie committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    e0bfe0d View commit details
    Browse the repository at this point in the history

  4. strip querystring from ESM imports in analyzeAndEmitDependency

    @lobsterkatie
    lobsterkatie committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    77c83bd View commit details
    Browse the repository at this point in the history

  5. cache seen status and analyze results under full path

    @lobsterkatie
    lobsterkatie committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    a8c294d View commit details
    Browse the repository at this point in the history

  6. try both rawPath and path when calling readFile

    @lobsterkatie
    lobsterkatie committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    142658c View commit details
    Browse the repository at this point in the history

  7. strip and store querystring in maybeEmitDep

    @lobsterkatie
    lobsterkatie committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    8c3ec63 View commit details
    Browse the repository at this point in the history

  8. use non-querystringed path when changing file extension in `maybeEmit… 

    …Dep`
    @lobsterkatie
    lobsterkatie committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    54431db View commit details
    Browse the repository at this point in the history

  9. force resolved to be an array in maybeEmitDep

    @lobsterkatie
    lobsterkatie committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    cc660e2 View commit details
    Browse the repository at this point in the history

  10. restore querystring when making recursive analyzeAndEmitDependency … 

    …call in `maybeEmitDep`
    @lobsterkatie
    lobsterkatie committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    bd5feee View commit details
    Browse the repository at this point in the history

  11. add tests

    @lobsterkatie
    lobsterkatie committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    a7c4822 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. use url.parse instead of custom RegExp

    @lforst
    lforst committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    b76cfeb View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. rename helper function and return values

    @lforst
    lforst committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    9eeed58 View commit details
    Browse the repository at this point in the history

  2. use new URL instead of url.parse

    @lforst
    lforst committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    44f3d3f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into lforst-preserve-query… 

    …string-when-resolving
    @lforst
    lforst committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    253e60c View commit details
    Browse the repository at this point in the history