chore: remove unused dependencies #1769
Conversation
|
Seems like it's working, pushing one more change and this should be ready |
| @@ -60,14 +59,6 @@ | |||
| "simple-git-hooks": ">=2.8.0", | |||
| "typescript": "4.7.2" | |||
| }, | |||
| "peerDependencies": { | |||
| "node-notifier": ">=9.0.1" | |||
There was a problem hiding this comment.
We do have dependency on "node-notifier" in "test-79-npm" at the moment.
There was a problem hiding this comment.
Yes, that's what I was trying to see in the first commit, and all the tests seems to pass.
It confirms my suspicion with the "peerDependenciesMeta" that this package won't be installed unless specified explicitly, so it's not installed even before this change, which we can confirm by looking at the lockfile not having "node-notifier" anywhere.
Another thing is that "test-79-npm" seems to download all the packages by itself using https module, which might not be the best approach to testing these kinds of stuff, but that would also mean we may not need any of those packages in the project's package.json.
|
This pull-request is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this pull-request entirely you can add the no-stale label |
|
What's left to do? |
baparham
dismissed
jesec’s stale review
issue seems addressed, maintainer no longer actively involved in project
|
I think it's reasonable to dismiss Jesse's review since he's no longer actively involved, and his original concern does seem to be addressed to me. I'll go ahead and dismiss the 'changes requested' flag, and document my justification here. |
|
@ignatiusmb perhaps a rebase and rerun of the tests and we'll see how that goes |
See if this works, we might be able to remove a lot of dependencies that's only used (
require-d) in tests