Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: align README example with style guide #82

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

lukahartwig
Copy link
Member

If you copy the example you immediately get a warning because the require statement doesn't use the node protocol.

@lukahartwig lukahartwig changed the title Align README example with style guide docs: align README example with style guide Dec 4, 2023
@mrmckeb mrmckeb merged commit cc100d8 into canary Dec 11, 2023
6 checks passed
@mrmckeb mrmckeb deleted the luka/align-readme-example-with-style-guide branch December 11, 2023 22:43
@mrmckeb
Copy link
Contributor

mrmckeb commented Dec 11, 2023

Thank you! I think that example was created before we enabled that rule - good catch!

@vercel-release-bot
Copy link
Collaborator

🎉 This PR is included in version 5.2.0-canary.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vercel-release-bot
Copy link
Collaborator

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants