Class re-writing mode

[rauchg]

For background: #4 (comment)
The transformation we might have to use would look like this:

<div className={ a ? 'b' : 'c' }></div>

becomes

import _styledJsxPrefix from 'styled-jsx'
<div className=_styledJsxPrefix('r4nd0m', { a ? 'b' : 'c' })></div>

and the implementation of _styledJsxPrefix would perform class prefixing

[robhrt7]

Definitely looking forward to have such option, not only it will help excluding less performant attr styles, but also:

• Keep selectors less specific
• Output smaller generated CSS

[rauchg]

Some elaboration on this.

If there's a tag selector:

p { }

it becomes

.$prefix_p { }

and each element gets a class with its tag name. ie: _styledJsxPrefix('$nonce', …, 'div')

If there's a class selector:

.woot { }

it becomes

.$prefix_woot { }

If there's an attribute selector:

[title=woot] {
  color: blue
}

it becomes

.$prefix[title=woot] {
  color: blue
}

and we make sure each element gets a generic random class as well, maybe by passing true as the last arg _styledJsxPrefix('$nonce', …, 'div', true)

[thysultan]

@rauchg

The following will produce conflicts

.p {}
p {}

.$prefix_p { }
.$prefix_p {}

class and ids should probably use a different delimiter to differentiate it from tag selectors.

.$prefix_p { }  /* tag */
.$prefix__p {} /* class */

[giuseppeg]

The following will produce conflicts

also it breaks the specificity model.

The current behaviour is the right one because it bumps the specificity of every selector by 0010. Similarly a solution that involves the use of classes should add a class to every element.

className=_styledJsxConcat('h4sh', originalExpression)

Result:

p.h4sh {}
.p.h4sh {}
*.h4sh {}
#test.h4sh {}
/* and so on */

[thysultan]

why is the hash after the user defined selector?

p {
color: red;
}

&:hover { color blue; }

to generate

.h4sh p { color:red; }
.h4sh:hover { color: red; }

and have the hash added to just the parent element

[giuseppeg]

.h4sh p will affect the entire subtree.

Also * { color: red } converted to .h4sh* { color: red } won't work

[rauchg]

For wildcard we can give a class to every element with the prefix

…

On Wed, Jan 4, 2017 at 6:18 AM Giuseppe ***@***.***> wrote: .h4sh p will affect the entire subtree. Also * { color: red } converted to .h4sh* { color: red } won't work — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAy8ZC8NhVaUQnbVm_MgZWOiSigVTTmks5rO6pAgaJpZM4LHR2n> .

[thysultan]

@giuseppeg * { color: red } would actually be .h4sh * {} ... what do you mean by

affect the entire subtree

shouldn't the selector p { color: red; } affect every p element in the namespace'd element? where as > p { color: red; } will only affect the immediate descendants.

so

<div>
	<p>only this paragraph will get the style :)</p>
	<style jsx>{`
	  p {
	    color: red;
	  }
	`}</style>
</div>

becomes

<div class="h4sh">
	<p>only this paragraph will get the style :)</p>
</div>

then & { selects div.h4sh then p { selects the p in div.h4sh and * { affects everything in the div.h4sh.

@rauchg does that mean you also have to apply the namespace to the elements children, and how far down the tree does this happen if that's the case.

[rauchg]

"affect the entire subtree" means that you're affecting elements of children components you don't know about

[rauchg]

Obviously you could force people to use > but the whole point is to invert that model, and disallow access to subtress unless explicitly (:global())

[thysultan]

You could auto insert the > otherwise you can run into cases where the output css and html is are large when using multiple selectors since every selector is getting a suffix and every element that matters is getting a class i.e

h1 span, h2 {}

will generate.

h1[data-jsx="woot"] span[data-jsx="woot"], h2[data-jsx="woot"] {}

[giuseppeg]

@thysultan size is not a problem gzip will do the magic since it is very repetitive data.

affect the entire subtree

I meant that in styled-jsx styles shouldn't cross the boundaries of the current component and therefore don't leak into nested components.

If you use the children selector > you'd have to reconstruct the dom structure to make sure that selectors match the right element(s). Imagine you have this dom

<div>
  <p>
    <span>zeit <span>rocks</span></span>
  </p>
</div>

and want to style the innermost span

span > span { color: red }

If you need to style it with the children selector the css should be:

div > p > span > span { color: red }

How would you do that? Also now you've increased the specificity of the selector.

[giuseppeg]

see #247

[yxh10]

Could someone please explain how this resolves the styled-jsx not working with antd components issue?

I still could not get styled-jsx working with antd. antd components' class name doesn't have the random number generated by style-jsx. Therefore, it never matches the style.

The workaround I have are:

1. modify the less file which affects the whole site if I don't add style contexts.
2. inline styling

I think either of the solutions is not ideal. Would be great to have a consistent solution across the whole project which is having styled-jsx to handle all the styling.

Thank you very much for any help in advance.

[guanpengchn]

@yxh10 Do you have any idea about your question? I have the same problem now.

[tbarkley]

@yxh10 I'm also having this same issue

[bryjch]

In case anyone is dealing with this problem in the future, seems it can now be handled by either using:

• resolve tag
• :global() styles

I feel that using :global() is slightly preferred because it can have standard jsx structure:

import { Layout } from 'antd'
const { Header, Content } = Layout

<Layout id="app">
  <Header id="header">
    ...
  </Header>

  <Content id="content">
    ...
  </Content>
</Layout>

<style jsx>{`
  :global(#app) { ... }
  :global(#header) { ... }
  :global(#content) { ... }
`}</style>

I guess as long as the components have sufficiently unique ids/classNames to prevent css conflicts, it shouldn't be a big problem.

[toFrankie]

Could someone please explain how this resolves the styled-jsx not working with antd components issue?

I still could not get styled-jsx working with antd. antd components' class name doesn't have the random number generated by style-jsx. Therefore, it never matches the style.

The workaround I have are:

1. modify the less file which affects the whole site if I don't add style contexts.
2. inline styling

I think either of the solutions is not ideal. Would be great to have a consistent solution across the whole project which is having styled-jsx to handle all the styling.

Thank you very much for any help in advance.

除了 resolve tag 有什么更为优雅的解决方案吗？