Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readme #135

Merged
merged 4 commits into from
Nov 20, 2019
Merged

Improve readme #135

merged 4 commits into from
Nov 20, 2019

Conversation

shuding
Copy link
Member

@shuding shuding commented Nov 19, 2019

  • add SSR
  • explain that args need to be stable on every render

pacocoursey
pacocoursey suggested changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@pacocoursey pacocoursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few wording changes to make it read smoothly.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
sergiodxa
sergiodxa reviewed Nov 19, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@shuding @pacocoursey @sergiodxa
Apply suggestions from code review
6c3d697 
Co-Authored-By: Paco <34928425+pacocoursey@users.noreply.github.com>
Co-Authored-By: Sergio Xalambrí <hello@sergiodxa.com>
shuding
shuding commented Nov 20, 2019
View reviewed changes
Copy link
Member Author

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you guys! @aequasi @pacocoursey @sergiodxa ❤️

@shuding shuding merged commit 97d75a6 into master Nov 20, 2019
@shuding shuding deleted the improve-readme branch November 20, 2019 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiodxa sergiodxa sergiodxa left review comments

@pacocoursey pacocoursey pacocoursey requested changes

@cryptiklemur cryptiklemur cryptiklemur approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuding @cryptiklemur @sergiodxa @pacocoursey